Bug 190069

Summary:

Replace every use of Node::offsetInCharacters() by Node::isCharacterDataNode()

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

DOM

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, darin, koivisto, sam, webkit-bug-importer, wenson_hsieh, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Cleanup	zalan: review+

Description Ryosuke Niwa 2018-09-27 21:39:48 PDT

The implementation of Node::offsetInCharacters() is identical to Node::isCharacterDataNode().

It's super confusing because offsetInCharacters() sounds like a function
which returns the number of characters in the node, or some kind of an offset within the characters.

Comment 1 Ryosuke Niwa 2018-09-27 21:45:19 PDT

Created attachment 351052 [details]
Cleanup

Comment 2 Ryosuke Niwa 2018-09-28 12:47:25 PDT

Committed r236607: <https://trac.webkit.org/changeset/236607>

Comment 3 Radar WebKit Bug Importer 2018-09-28 12:48:31 PDT

<rdar://problem/44872083>