Bug 190064

Summary:

Don't use int offsets in StructureStubInfo

Product:

WebKit

Reporter:

Saam Barati <saam>

Component:

JavaScriptCore

Assignee:

Saam Barati <saam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, fpizlo, ggaren, gskachkov, keith_miller, mark.lam, msaboff, rmorisset, ticaiolima, webkit-bug-importer, ysuzuki

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	mark.lam: review+

Description Saam Barati 2018-09-27 17:53:16 PDT

...

Comment 1 Saam Barati 2018-09-27 17:54:16 PDT

<rdar://problem/44784719>

Comment 2 Saam Barati 2018-09-27 18:51:38 PDT

Created attachment 351036 [details]
patch

Comment 3 Mark Lam 2018-09-27 21:05:14 PDT

Comment on attachment 351036 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=351036&action=review

r=me.

> Source/JavaScriptCore/bytecode/StructureStubInfo.h:189
>          RegisterSet usedRegisters;

I suggest moving this after the CodeLocations for better packing of this struct.  It was well packed before with the trailing 32-bit ints.  It won't be anymore with the 64-bit CodeLocations, unless we move it after.

Comment 4 Saam Barati 2018-09-27 21:27:32 PDT

landed in:
https://trac.webkit.org/changeset/236584/webkit