Summary: | Increase the timeout for iOS Simulator data migration | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryan Haddad <ryanhaddad> | ||||||
Component: | Tools / Tests | Assignee: | Ryan Haddad <ryanhaddad> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | aakash_jain, ews-watchlist, glenn, jbedard, lforschler, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | Other | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Ryan Haddad
2018-09-27 15:42:11 PDT
Created attachment 351018 [details]
Patch
Comment on attachment 351018 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=351018&action=review > Tools/Scripts/webkitpy/xcode/simulated_device.py:64 > + DEFAULT_TIMEOUT = 60 I think this should be 600 Created attachment 351027 [details]
Patch
Unofficial r=me. Comment on attachment 351027 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=351027&action=review > Tools/Scripts/webkitpy/xcode/simulated_device.py:64 > + DEFAULT_TIMEOUT = 600 This variable can be named better, to indicate what kind of timeout it is. (In reply to Aakash Jain from comment #5) > Comment on attachment 351027 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=351027&action=review > > > Tools/Scripts/webkitpy/xcode/simulated_device.py:64 > > + DEFAULT_TIMEOUT = 600 > > This variable can be named better, to indicate what kind of timeout it is. Perhaps SIMULATOR_BOOT_TIMEOUT is more appropriate. Landed in https://trac.webkit.org/r236579 |