Bug 190059

Summary: Increase the timeout for iOS Simulator data migration
Product: WebKit Reporter: Ryan Haddad <ryanhaddad>
Component: Tools / TestsAssignee: Ryan Haddad <ryanhaddad>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ews-watchlist, glenn, jbedard, lforschler, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch aakash_jain: review+

Ryan Haddad
Reported 2018-09-27 15:42:11 PDT
Increase the timeout for iOS Simulator data migration since 3 minutes isn't always enough time for the data migrator to complete when booting up multiple iOS Simulators
Attachments
Patch (3.38 KB, patch)
2018-09-27 16:17 PDT, Ryan Haddad 		no flags
DetailsFormatted DiffDiff
Patch (3.38 KB, patch)
2018-09-27 17:16 PDT, Ryan Haddad 		aakash_jain: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryan Haddad
Comment 1 2018-09-27 16:17:04 PDT
Created attachment 351018 [details] Patch
Jonathan Bedard
Comment 2 2018-09-27 17:15:13 PDT
Comment on attachment 351018 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=351018&action=review > Tools/Scripts/webkitpy/xcode/simulated_device.py:64 > + DEFAULT_TIMEOUT = 60 I think this should be 600
Ryan Haddad
Comment 3 2018-09-27 17:16:18 PDT
Created attachment 351027 [details] Patch
Jonathan Bedard
Comment 4 2018-09-27 17:16:41 PDT
Unofficial r=me.
Aakash Jain
Comment 5 2018-09-27 17:30:23 PDT
Comment on attachment 351027 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=351027&action=review > Tools/Scripts/webkitpy/xcode/simulated_device.py:64 > + DEFAULT_TIMEOUT = 600 This variable can be named better, to indicate what kind of timeout it is.
Ryan Haddad
Comment 6 2018-09-27 17:41:37 PDT
(In reply to Aakash Jain from comment #5) > Comment on attachment 351027 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=351027&action=review > > > Tools/Scripts/webkitpy/xcode/simulated_device.py:64 > > + DEFAULT_TIMEOUT = 600 > > This variable can be named better, to indicate what kind of timeout it is. Perhaps SIMULATOR_BOOT_TIMEOUT is more appropriate.
Ryan Haddad
Comment 7 2018-09-27 17:50:55 PDT
Landed in https://trac.webkit.org/r236579
Radar WebKit Bug Importer
Comment 8 2018-09-27 17:51:29 PDT
<rdar://problem/44850684>
Note You need to log in before you can comment on or make changes to this bug.