| Summary: | [Payment Request] Update web platform tests | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Andy Estes <aestes> | ||||
| Component: | New Bugs | Assignee: | Andy Estes <aestes> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | achristensen, aestes, andersca, cdumez, commit-queue, eric.carlson, jiewen_tan, sam, simon.fraser, thorton, webkit-bug-importer, wenson_hsieh, youennf | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Andy Estes
2018-09-27 12:47:25 PDT
Created attachment 350988 [details]
Patch
Comment on attachment 350988 [details] Patch r=me once bots are green. View in context: https://bugs.webkit.org/attachment.cgi?id=350988&action=review > LayoutTests/platform/mac-wk2/TestExpectations:863 > +imported/w3c/web-platform-tests/payment-request/payment-response/onpayerdetailchange-attribute-manual.https.html [ Skip ] The importer should by default not import manual tests. Do we need these in WebKit repo? (In reply to youenn fablet from comment #2) > Comment on attachment 350988 [details] > Patch > > r=me once bots are green. > > View in context: > https://bugs.webkit.org/attachment.cgi?id=350988&action=review > > > LayoutTests/platform/mac-wk2/TestExpectations:863 > > +imported/w3c/web-platform-tests/payment-request/payment-response/onpayerdetailchange-attribute-manual.https.html [ Skip ] > > The importer should by default not import manual tests. > Do we need these in WebKit repo? I feel like I must be doing something wrong, because the importer has been importing manual tests even though I don't specify -a. Maybe the payment-request manual tests don't match the naming format expected by the importer? That said, the manual tests are kinda helpful. Some of them I've converted to automated tests using internals.mockPaymentCoordinator (in http/tests/paymentrequest). > I feel like I must be doing something wrong, because the importer has been > importing manual tests even though I don't specify -a. Maybe the > payment-request manual tests don't match the naming format expected by the > importer? Or maybe we regressed the importer! > That said, the manual tests are kinda helpful. Some of them I've converted > to automated tests using internals.mockPaymentCoordinator (in > http/tests/paymentrequest). It seems sad that we could not share these internal-based tests in WPT since probably other browsers do something similar. Might be something we should push for upstream. (In reply to youenn fablet from comment #4) > > I feel like I must be doing something wrong, because the importer has been > > importing manual tests even though I don't specify -a. Maybe the > > payment-request manual tests don't match the naming format expected by the > > importer? > > Or maybe we regressed the importer! I'll investigate. > > > That said, the manual tests are kinda helpful. Some of them I've converted > > to automated tests using internals.mockPaymentCoordinator (in > > http/tests/paymentrequest). > > It seems sad that we could not share these internal-based tests in WPT since > probably other browsers do something similar. Might be something we should > push for upstream. Yeah, we can do better here. I think this would be a good thing to talk about with the Web Payments WG at TPAC. Comment on attachment 350988 [details] Patch Clearing flags on attachment: 350988 Committed r236570: <https://trac.webkit.org/changeset/236570> All reviewed patches have been landed. Closing bug. |