Bug 190019

Summary: [iOS] Allow access to VoiceServices features needed for accessibility
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit2Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, cfleizach, commit-queue, jcraig, pvollan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 181619    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Brent Fulgham
Reported 2018-09-26 17:15:38 PDT
I tightened the sandbox too far in Bug 181619, causing some non-US English voice WebSpeech features to stop working. This patch expands the sandbox to allow those features to work properly in iOS 12.
Attachments
Patch (2.06 KB, patch)
2018-09-26 17:19 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch (1.50 KB, patch)
2018-09-27 12:10 PDT, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2018-09-26 17:17:58 PDT
<rdar://problem/43621111>
Brent Fulgham
Comment 2 2018-09-26 17:19:53 PDT
Created attachment 350928 [details] Patch
chris fleizach
Comment 3 2018-09-26 17:26:37 PDT
Comment on attachment 350928 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=350928&action=review > Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:99 > + (global-name "com.apple.voiceservices.keepalive") ; Needed for non-US english language synthesis suspect these are not technically needed.
Per Arne Vollan
Comment 4 2018-09-27 11:57:23 PDT
(In reply to chris fleizach from comment #3) > Comment on attachment 350928 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=350928&action=review > > > Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:99 > > + (global-name "com.apple.voiceservices.keepalive") ; Needed for non-US english language synthesis > > suspect these are not technically needed. I will remove these.
Per Arne Vollan
Comment 5 2018-09-27 12:10:54 PDT
Created attachment 350984 [details] Patch
Per Arne Vollan
Comment 6 2018-09-27 13:45:09 PDT
Comment on attachment 350984 [details] Patch Thanks for reviewing!
WebKit Commit Bot
Comment 7 2018-09-27 14:28:00 PDT
Comment on attachment 350984 [details] Patch Clearing flags on attachment: 350984 Committed r236571: <https://trac.webkit.org/changeset/236571>
WebKit Commit Bot
Comment 8 2018-09-27 14:28:02 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.