| Summary: | Split NaN-check into separate test | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dominik Inführ <dominik.infuehr> | ||||||||
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | commit-queue, ews-watchlist, guijemont, mcatanzaro, msaboff, saam, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Dominik Inführ
2018-09-26 14:01:34 PDT
Created attachment 350900 [details]
Patch
Comment on attachment 350900 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=350900&action=review > JSTests/ChangeLog:9 > + DataView exposes NaN-representation, which is not necessarily the same on each > + architecture. Therefore move the check of the NaN-representation into its own > + file such that we can disable this test on MIPS where NaN-representation can be > + different on older CPUs. nit: Please move this underneath the "Reviewed by" Created attachment 350954 [details]
Patch
Thank you very much for the review! I've updated the ChangeLog. Comment on attachment 350954 [details] Patch Attachment 350954 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/9366830 New failing tests: storage/indexeddb/cursor-update.html Created attachment 350955 [details]
Archive of layout-test-results from ews113 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113 Port: mac-sierra Platform: Mac OS X 10.12.6
(In reply to Build Bot from comment #5) > Comment on attachment 350954 [details] > Patch > > Attachment 350954 [details] did not pass mac-debug-ews (mac): > Output: https://webkit-queues.webkit.org/results/9366830 > > New failing tests: > storage/indexeddb/cursor-update.html This test has been flaky for years. Really needs to be marked accordingly. Comment on attachment 350954 [details] Patch Clearing flags on attachment: 350954 Committed r236684: <https://trac.webkit.org/changeset/236684> All reviewed patches have been landed. Closing bug. |