Bug 189949

Summary: [JSC] offlineasm parser should handle CRLF in asm files
Product: WebKit Reporter: Koby <koby.b>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, fpizlo, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 189947    
Attachments:
Description Flags
Patch none

Koby
Reported 2018-09-25 08:44:12 PDT
When working on Windows, LLInt's asm files might contain CRLFs, which currently fail the offlineasm parser. This patch removes '\r's from the input file.
Attachments
Patch (2.12 KB, patch)
2018-09-25 09:10 PDT, Koby 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Koby
Comment 1 2018-09-25 09:10:16 PDT
Created attachment 350752 [details] Patch
Mark Lam
Comment 2 2018-09-25 09:37:56 PDT
Comment on attachment 350752 [details] Patch r=me
Mark Lam
Comment 3 2018-09-25 15:31:13 PDT
@Koby, in case you are new to WebKit development, since you don't have commit privileges yet, if you want a patch to be landed once a reviewer has granted a r+, you should set the cq flag to cq?. That will tell the reviewer or other committers that you're done with the patch and that it's ready to land.
Koby
Comment 4 2018-09-26 01:33:43 PDT
@Mark thanks, I am new and this is actually the first patch I'm trying to upload. To set the cq flag, should I use webkit-patch land-safely?
Yusuke Suzuki
Comment 5 2018-09-26 01:41:01 PDT
(In reply to Koby from comment #4) > @Mark thanks, I am new and this is actually the first patch I'm trying to > upload. To set the cq flag, should I use webkit-patch land-safely? You can set `cq?` flag for already uploaded patches in this web page. Or passing `--request-commit` flag to `webkit-patch upload` when uploading the patch. In this case, your patch is already marked as `r+`. So just setting `cq=?` to the uploaded patch works fine :)
Koby
Comment 6 2018-09-26 03:20:44 PDT
Done :) The "Reviewed by NOBODY (OOPS!)." will updated automatically?
WebKit Commit Bot
Comment 7 2018-09-26 03:45:45 PDT
Comment on attachment 350752 [details] Patch Clearing flags on attachment: 350752 Committed r236499: <https://trac.webkit.org/changeset/236499>
WebKit Commit Bot
Comment 8 2018-09-26 03:45:46 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2018-09-26 03:46:34 PDT
<rdar://problem/44791913>
Yusuke Suzuki
Comment 10 2018-09-26 04:06:33 PDT
(In reply to Koby from comment #6) > Done :) The "Reviewed by NOBODY (OOPS!)." will updated automatically? Yes!
Note You need to log in before you can comment on or make changes to this bug.