Bug 189946

Summary: Move Symbol API to SPI
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: New BugsAssignee: Keith Miller <keith_miller>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, mark.lam, mitz, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch msaboff: review+

Keith Miller
Reported 2018-09-25 08:01:44 PDT
Move Symbol API to SPI
Attachments
Patch (19.52 KB, patch)
2018-09-25 08:03 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch (23.02 KB, patch)
2018-09-25 11:36 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch (23.31 KB, patch)
2018-09-25 12:05 PDT, Keith Miller 		msaboff: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2018-09-25 08:03:10 PDT
Created attachment 350751 [details] Patch
EWS Watchlist
Comment 2 2018-09-25 08:04:52 PDT
Attachment 350751 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/API/JSObjectRefPrivate.h:94: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSObjectRefPrivate.h:106: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSObjectRefPrivate.h:119: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSObjectRefPrivate.h:119: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSObjectRefPrivate.h:119: The parameter name "attributes" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSObjectRefPrivate.h:131: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 6 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Keith Miller
Comment 3 2018-09-25 11:36:47 PDT
Created attachment 350771 [details] Patch
EWS Watchlist
Comment 4 2018-09-25 11:48:03 PDT
Attachment 350771 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/API/JSObjectRefPrivate.h:94: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSObjectRefPrivate.h:106: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSObjectRefPrivate.h:119: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSObjectRefPrivate.h:119: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSObjectRefPrivate.h:119: The parameter name "attributes" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSObjectRefPrivate.h:131: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSObjectRefPrivate.h:140: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 7 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Keith Miller
Comment 5 2018-09-25 12:05:58 PDT
Created attachment 350776 [details] Patch
EWS Watchlist
Comment 6 2018-09-25 12:08:56 PDT
Attachment 350776 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/API/JSObjectRefPrivate.h:94: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSObjectRefPrivate.h:106: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSObjectRefPrivate.h:119: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSObjectRefPrivate.h:119: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSObjectRefPrivate.h:119: The parameter name "attributes" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSObjectRefPrivate.h:131: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSObjectRefPrivate.h:140: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 7 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Michael Saboff
Comment 7 2018-09-26 12:55:28 PDT
Comment on attachment 350776 [details] Patch rs=me
Keith Miller
Comment 8 2018-09-26 13:04:33 PDT
Committed r236520: <https://trac.webkit.org/changeset/236520>
Radar WebKit Bug Importer
Comment 9 2018-09-26 13:05:22 PDT
<rdar://problem/44805073>
Note You need to log in before you can comment on or make changes to this bug.