Bug 189937

Summary: Don't cause a crash even when some IDL attribute is missing CEReactions
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: DOMAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, dbates, esprehn+autocc, ews-watchlist, ggaren, kangil.han, koivisto, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 154907    
Attachments:
Description Flags
Don't release-assert even when CEReactions is missing simon.fraser: review+

Ryosuke Niwa
Reported 2018-09-24 17:06:27 PDT
It's not a good trade-off to cause a release assertion hit when there is an IDL attribute missing CEReactions. Turn this into a debug-only assertion.
Attachments
Don't release-assert even when CEReactions is missing (2.64 KB, patch)
2018-09-24 17:12 PDT, Ryosuke Niwa 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2018-09-24 17:12:13 PDT
Created attachment 350715 [details] Don't release-assert even when CEReactions is missing
Radar WebKit Bug Importer
Comment 2 2018-09-24 17:17:46 PDT
<rdar://problem/44746785>
Ryosuke Niwa
Comment 3 2018-09-24 17:28:44 PDT
Committed r236446: <https://trac.webkit.org/changeset/236446>
Note You need to log in before you can comment on or make changes to this bug.