Bug 189881

Summary: WebPageProxy::reattachToWebProcess cleanups
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, commit-queue, ggaren, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
patch
none
patch none

Description Antti Koivisto 2018-09-22 00:54:51 PDT 
Change the factoring to separate swap and crash code paths into different functions.
Comment 1 Antti Koivisto 2018-09-22 00:58:56 PDT 
Created attachment 350502 [details]
patch
Comment 2 Antti Koivisto 2018-09-22 01:49:44 PDT 
Created attachment 350506 [details]
patch
Comment 3 Alex Christensen 2018-09-25 10:40:06 PDT 
Comment on attachment 350506 [details]
patch

The unexpected timeouts in the Mac-wk2 bot are concerning.
Comment 4 Antti Koivisto 2018-09-25 11:16:46 PDT 
I suspect it was unrelated but I can re-EWS this.
Comment 5 Antti Koivisto 2018-09-25 11:17:34 PDT 
Created attachment 350765 [details]
patch
Comment 6 WebKit Commit Bot 2018-10-02 09:15:14 PDT 
Comment on attachment 350765 [details]
patch

Clearing flags on attachment: 350765

Committed r236746: <https://trac.webkit.org/changeset/236746>
Comment 7 WebKit Commit Bot 2018-10-02 09:15:16 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2018-10-02 09:16:26 PDT 
<rdar://problem/44940150>