Bug 189881

Summary: WebPageProxy::reattachToWebProcess cleanups
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, commit-queue, ggaren, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
patch
none
patch none

Antti Koivisto
Reported 2018-09-22 00:54:51 PDT
Change the factoring to separate swap and crash code paths into different functions.
Attachments
patch (5.72 KB, patch)
2018-09-22 00:58 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
patch (5.72 KB, patch)
2018-09-22 01:49 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
patch (5.72 KB, patch)
2018-09-25 11:17 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2018-09-22 00:58:56 PDT
Created attachment 350502 [details] patch
Antti Koivisto
Comment 2 2018-09-22 01:49:44 PDT
Created attachment 350506 [details] patch
Alex Christensen
Comment 3 2018-09-25 10:40:06 PDT
Comment on attachment 350506 [details] patch The unexpected timeouts in the Mac-wk2 bot are concerning.
Antti Koivisto
Comment 4 2018-09-25 11:16:46 PDT
I suspect it was unrelated but I can re-EWS this.
Antti Koivisto
Comment 5 2018-09-25 11:17:34 PDT
Created attachment 350765 [details] patch
WebKit Commit Bot
Comment 6 2018-10-02 09:15:14 PDT
Comment on attachment 350765 [details] patch Clearing flags on attachment: 350765 Committed r236746: <https://trac.webkit.org/changeset/236746>
WebKit Commit Bot
Comment 7 2018-10-02 09:15:16 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2018-10-02 09:16:26 PDT
<rdar://problem/44940150>
Note You need to log in before you can comment on or make changes to this bug.