Bug 189877

Summary: [WebAuthN] Import a JS CBOR coder
Product: WebKit Reporter: Jiewen Tan <jiewen_tan>
Component: Tools / TestsAssignee: Jiewen Tan <jiewen_tan>
Status: RESOLVED FIXED    
Severity: Normal CC: alex.gaynor, bfulgham, cdumez, commit-queue, ews-watchlist, jiewen_tan, lforschler, simon.fraser, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 182769    
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews123 for ios-simulator-wk2
none
Patch none

Description Jiewen Tan 2018-09-21 21:46:33 PDT 
We need to import a JS CBOR coder in order to check responds in layout tests.

One of the candidate is: https://github.com/paroga/cbor-js.
Comment 1 Radar WebKit Bug Importer 2018-09-21 21:48:22 PDT 
<rdar://problem/44701124>
Comment 2 Jiewen Tan 2018-09-28 18:05:26 PDT 
Created attachment 351153 [details]
Patch
Comment 3 EWS Watchlist 2018-09-29 03:45:55 PDT 
Comment on attachment 351153 [details]
Patch

Attachment 351153 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/9391951

New failing tests:
http/wpt/credential-management/credentialscontainer-store-basics.https.html
Comment 4 EWS Watchlist 2018-09-29 03:45:57 PDT 
Created attachment 351178 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6
Comment 5 Jiewen Tan 2018-09-29 20:24:48 PDT 
Created attachment 351208 [details]
Patch
Comment 6 Chris Dumez 2018-10-01 12:36:15 PDT 
Comment on attachment 351208 [details]
Patch

r=me
Comment 7 Jiewen Tan 2018-10-01 12:42:36 PDT 
(In reply to Chris Dumez from comment #6)
> Comment on attachment 351208 [details]
> Patch
> 
> r=me

Thanks, Chris.
Comment 8 WebKit Commit Bot 2018-10-01 12:47:15 PDT 
Comment on attachment 351208 [details]
Patch

Clearing flags on attachment: 351208

Committed r236686: <https://trac.webkit.org/changeset/236686>
Comment 9 WebKit Commit Bot 2018-10-01 12:47:16 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 10 Simon Fraser (smfr) 2018-10-01 13:13:23 PDT 
Comment on attachment 351208 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=351208&action=review

> Source/WebKit/ChangeLog:10
> +        as Local's memeber such that tests can pass those certificates to MockLocalConnection instead of letting it

memeber -> member

> Source/WebKit/ChangeLog:11
> +        holds some static ones.

holds -> hold

> LayoutTests/ChangeLog:9
> +        This patch import a 3rd party JS CBOR coder from https://github.com/paroga/cbor-js.

imports
Comment 11 Jiewen Tan 2018-10-01 13:28:35 PDT 
Comment on attachment 351208 [details]
Patch

Oops, it seems too late this time to correct those grammar issues. I will pay more attentions to it next time. Thanks for reviewing, Simon.