Bug 189872

Summary:

Video track clone cannot preserve original property

Product:

WebKit

Reporter:

Wendy <yuhan_wu>

Component:

WebRTC

Assignee:

Wendy <yuhan_wu>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, eric.carlson, jer.noble, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description Wendy 2018-09-21 18:50:45 PDT

use canvas.captureStream to create a video track, and the cloned track will not keep the property such as enabled compared with original track.

Comment 1 Radar WebKit Bug Importer 2018-09-22 11:19:32 PDT

<rdar://problem/44706579>

Comment 2 Wendy 2018-09-26 16:16:23 PDT

Created attachment 350920 [details]
Patch

Comment 3 youenn fablet 2018-09-26 16:41:14 PDT

Comment on attachment 350920 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=350920&action=review

> Source/WebCore/ChangeLog:8
> +

Can you provide more information about changes?
For instance describe what was the issue.

> Source/WebCore/Modules/mediastream/CanvasCaptureMediaStreamTrack.h:43
> +    static Ref<CanvasCaptureMediaStreamTrack> create(ScriptExecutionContext&, Ref<HTMLCanvasElement>&&, Ref<MediaStreamTrackPrivate>&& privateTrack);

It might be good to not define this create() method and directly call adoptRef(*new ...) in CanvasCaptureMediaStreamTrack::clone().

Comment 4 Wendy 2018-09-26 17:15:14 PDT

Created attachment 350927 [details]
Patch

Comment 5 WebKit Commit Bot 2018-09-26 18:42:31 PDT

Comment on attachment 350927 [details]
Patch

Clearing flags on attachment: 350927

Committed r236536: <https://trac.webkit.org/changeset/236536>

Comment 6 WebKit Commit Bot 2018-09-26 18:42:33 PDT

All reviewed patches have been landed.  Closing bug.