Bug 189868

Summary: [MSE][GStreamer] Use no-more-pads event for noticing initialization segments
Product: WebKit Reporter: Alicia Boya García <aboya>
Component: WebKitGTKAssignee: Alicia Boya García <aboya>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, calvaris, commit-queue
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Alicia Boya García
Reported 2018-09-21 16:59:18 PDT
Fixes the following YTTV 2018 tests: 62.VideoDimensionVP9 63.PlaybackStateVP9 This removes the hack that was making supporting multiple tracks in the same file in MSE impossible. For WebM, this GStreamer patch is required: https://bugzilla.gnome.org/show_bug.cgi?id=797187 "matroskademux: Emit no-more-pads after parsing Tracks"
Attachments
Patch (6.75 KB, patch)
2018-09-21 17:00 PDT, Alicia Boya García 		no flags
DetailsFormatted DiffDiff
Patch (11.18 KB, patch)
2018-09-24 05:44 PDT, Alicia Boya García 		no flags
DetailsFormatted DiffDiff
Patch (11.18 KB, patch)
2018-09-24 05:52 PDT, Alicia Boya García 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alicia Boya García
Comment 1 2018-09-21 17:00:20 PDT
Created attachment 350458 [details] Patch
Xabier Rodríguez Calvar
Comment 2 2018-09-23 22:50:28 PDT
Comment on attachment 350458 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=350458&action=review > Source/WebCore/ChangeLog:17 > + For WebM, this GStreamer patch is required: > + https://bugzilla.gnome.org/show_bug.cgi?id=797187 > + "matroskademux: Emit no-more-pads after parsing Tracks" Why are you not including this patch as part of our JHBuild conf?
Alicia Boya García
Comment 3 2018-09-24 05:44:26 PDT
Created attachment 350634 [details] Patch
Alicia Boya García
Comment 4 2018-09-24 05:52:39 PDT
Created attachment 350635 [details] Patch
WebKit Commit Bot
Comment 5 2018-09-24 06:31:27 PDT
Comment on attachment 350635 [details] Patch Clearing flags on attachment: 350635 Committed r236399: <https://trac.webkit.org/changeset/236399>
WebKit Commit Bot
Comment 6 2018-09-24 06:31:28 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.