Bug 189863

Summary:

Import html/webappapis/dynamic-markup-insertion WPT tests

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

Tools / Tests

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, ews-watchlist, lforschler, tsavell, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

189917, 189373

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews112 for mac-sierra	none
Patch	none

Chris Dumez

Reported 2018-09-21 15:24:54 PDT

Import html/webappapis/dynamic-markup-insertion WPT tests.

Attachments
Patch (431.71 KB, patch) 2018-09-21 15:31 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews112 for mac-sierra (3.52 MB, application/zip) 2018-09-21 18:37 PDT, EWS Watchlist	no flags	Details
Patch (432.23 KB, patch) 2018-09-24 08:52 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Chris Dumez

Comment 1 2018-09-21 15:31:42 PDT

Created attachment 350442 [details] Patch

youenn fablet

Comment 2 2018-09-21 15:51:31 PDT

Comment on attachment 350442 [details] Patch r=me once bots are happy

EWS Watchlist

Comment 3 2018-09-21 18:37:51 PDT

Comment on attachment 350442 [details] Patch Attachment 350442 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/9305353 New failing tests: imported/w3c/web-platform-tests/html/webappapis/dynamic-markup-insertion/document-write/contentType.window.html

EWS Watchlist

Comment 4 2018-09-21 18:37:54 PDT

Created attachment 350469 [details] Archive of layout-test-results from ews112 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-sierra Platform: Mac OS X 10.12.6

Chris Dumez

Comment 5 2018-09-24 08:52:11 PDT

Created attachment 350641 [details] Patch

WebKit Commit Bot

Comment 6 2018-09-24 09:55:38 PDT

Comment on attachment 350641 [details] Patch Clearing flags on attachment: 350641 Committed r236405: <https://trac.webkit.org/changeset/236405>

WebKit Commit Bot

Comment 7 2018-09-24 09:55:40 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 8 2018-09-24 09:56:28 PDT

<rdar://problem/44729460>

Truitt Savell

Comment 9 2018-09-24 12:34:15 PDT

Looks like the Newley imported test imported/w3c/web-platform-tests/html/webappapis/dynamic-markup-insertion/document-write/contentType.window.html Imported in: https://trac.webkit.org/changeset/236405/webkit is a flakey timeout. History: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=imported%2Fw3c%2Fweb-platform-tests%2Fhtml%2Fwebappapis%2Fdynamic-markup-insertion%2Fdocument-write%2FcontentType.window.html

Chris Dumez

Comment 10 2018-09-24 12:39:00 PDT

(In reply to Truitt Savell from comment #9) > Looks like the Newley imported test > imported/w3c/web-platform-tests/html/webappapis/dynamic-markup-insertion/ > document-write/contentType.window.html > > Imported in: https://trac.webkit.org/changeset/236405/webkit > > is a flakey timeout. > > History: > https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard. > html#showAllRuns=true&tests=imported%2Fw3c%2Fweb-platform- > tests%2Fhtml%2Fwebappapis%2Fdynamic-markup-insertion%2Fdocument- > write%2FcontentType.window.html And I already knew it was crashing in Debug (see associated bug). I'll skip it until I can investigate.

Chris Dumez

Comment 11 2018-09-24 12:42:43 PDT

(In reply to Chris Dumez from comment #10) > (In reply to Truitt Savell from comment #9) > > Looks like the Newley imported test > > imported/w3c/web-platform-tests/html/webappapis/dynamic-markup-insertion/ > > document-write/contentType.window.html > > > > Imported in: https://trac.webkit.org/changeset/236405/webkit > > > > is a flakey timeout. > > > > History: > > https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard. > > html#showAllRuns=true&tests=imported%2Fw3c%2Fweb-platform- > > tests%2Fhtml%2Fwebappapis%2Fdynamic-markup-insertion%2Fdocument- > > write%2FcontentType.window.html > > And I already knew it was crashing in Debug (see associated bug). I'll skip > it until I can investigate. <https://trac.webkit.org/changeset/236419>

Note You need to log in before you can comment on or make changes to this bug.