Bug 189860

Summary: Web Inspector: determine hasVisibleEffect for each RecordingAction as it's processed
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, inspector-bugzilla-changes, joepeck, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 173807, 175485    
Attachments:
Description Flags
Patch
none
Patch none

Devin Rousso
Reported 2018-09-21 15:02:24 PDT
Ever since <https://webkit.org/b/185152>, we now process recordings in a much more non-blocking way, meaning that we can do a bit more work for each action. As such, we should attempt to determine `hasVisibleEffect` during this time, as if the experimental flag created in <https://webkit.org/b/185758> was always enabled.
Attachments
Patch (18.32 KB, patch)
2018-09-21 15:27 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (19.05 KB, patch)
2018-09-26 22:31 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2018-09-21 15:27:15 PDT
Created attachment 350441 [details] Patch
Joseph Pecoraro
Comment 2 2018-09-26 16:44:32 PDT
Comment on attachment 350441 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=350441&action=review r=me, nice! > Source/WebInspectorUI/UserInterface/Base/Utilities.js:430 > + function isArray(x) { How about naming this `isArrayLike` or `isNativeArrayType`
Devin Rousso
Comment 3 2018-09-26 22:31:28 PDT
Created attachment 350943 [details] Patch
WebKit Commit Bot
Comment 4 2018-09-26 23:09:55 PDT
Comment on attachment 350943 [details] Patch Clearing flags on attachment: 350943 Committed r236539: <https://trac.webkit.org/changeset/236539>
WebKit Commit Bot
Comment 5 2018-09-26 23:09:57 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2018-09-26 23:10:23 PDT
<rdar://problem/44820587>
Note You need to log in before you can comment on or make changes to this bug.