Bug 189860

Summary: Web Inspector: determine hasVisibleEffect for each RecordingAction as it's processed
Product: WebKit Reporter: Devin Rousso <drousso>
Component: Web InspectorAssignee: Devin Rousso <drousso>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, inspector-bugzilla-changes, joepeck, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 173807, 175485    
Attachments:
Description Flags
Patch
none
Patch none

Description Devin Rousso 2018-09-21 15:02:24 PDT
Ever since <https://webkit.org/b/185152>, we now process recordings in a much more non-blocking way, meaning that we can do a bit more work for each action.  As such, we should attempt to determine `hasVisibleEffect` during this time, as if the experimental flag created in <https://webkit.org/b/185758> was always enabled.
Comment 1 Devin Rousso 2018-09-21 15:27:15 PDT
Created attachment 350441 [details]
Patch
Comment 2 Joseph Pecoraro 2018-09-26 16:44:32 PDT
Comment on attachment 350441 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=350441&action=review

r=me, nice!

> Source/WebInspectorUI/UserInterface/Base/Utilities.js:430
> +        function isArray(x) {

How about naming this `isArrayLike` or `isNativeArrayType`
Comment 3 Devin Rousso 2018-09-26 22:31:28 PDT
Created attachment 350943 [details]
Patch
Comment 4 WebKit Commit Bot 2018-09-26 23:09:55 PDT
Comment on attachment 350943 [details]
Patch

Clearing flags on attachment: 350943

Committed r236539: <https://trac.webkit.org/changeset/236539>
Comment 5 WebKit Commit Bot 2018-09-26 23:09:57 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-09-26 23:10:23 PDT
<rdar://problem/44820587>