Bug 189854

Summary: Import WPT content hint tests
Product: WebKit Reporter: Wendy <yuhan_wu>
Component: WebRTCAssignee: Wendy <yuhan_wu>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ryanhaddad, tsavell, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Wendy
Reported 2018-09-21 13:31:21 PDT
import a contentment test case from W3C
Attachments
Patch (10.42 KB, patch)
2018-09-21 13:33 PDT, Wendy 		no flags
DetailsFormatted DiffDiff
Patch (10.37 KB, patch)
2018-09-21 14:57 PDT, Wendy 		no flags
DetailsFormatted DiffDiff
Patch (11.54 KB, patch)
2018-09-24 12:08 PDT, Wendy 		no flags
DetailsFormatted DiffDiff
Patch (11.42 KB, patch)
2018-09-24 12:17 PDT, Wendy 		no flags
DetailsFormatted DiffDiff
Patch (2.15 KB, patch)
2018-09-24 13:37 PDT, Wendy 		no flags
DetailsFormatted DiffDiff
Patch (1.73 KB, patch)
2018-09-25 11:04 PDT, Wendy 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Wendy
Comment 1 2018-09-21 13:33:40 PDT
Created attachment 350416 [details] Patch
youenn fablet
Comment 2 2018-09-21 13:34:39 PDT
Comment on attachment 350416 [details] Patch r=me. Let's land it once bots are green.
youenn fablet
Comment 3 2018-09-21 14:02:08 PDT
Bug title should be renamed to "Import WPT content hint tests". ChangeLog does not need "expected result" and "new-tests" lines.
Wendy
Comment 4 2018-09-21 14:57:49 PDT
Created attachment 350434 [details] Patch
WebKit Commit Bot
Comment 5 2018-09-21 16:06:49 PDT
Comment on attachment 350434 [details] Patch Clearing flags on attachment: 350434 Committed r236367: <https://trac.webkit.org/changeset/236367>
WebKit Commit Bot
Comment 6 2018-09-21 16:06:50 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2018-09-21 16:07:26 PDT
<rdar://problem/44695832>
Truitt Savell
Comment 8 2018-09-21 17:23:51 PDT
After https://trac.webkit.org/changeset/236367/webkit the new test imported/w3c/web-platform-tests/mst-content-hint/idlharness.window.html does not have an expectation file and is showing missing results in history History: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=imported%2Fw3c%2Fweb-platform-tests%2Fmst-content-hint%2Fidlharness.window.html
Wendy
Comment 9 2018-09-24 12:08:53 PDT
Reopening to attach new patch.
Wendy
Comment 10 2018-09-24 12:08:54 PDT
Created attachment 350659 [details] Patch
Wendy
Comment 11 2018-09-24 12:17:43 PDT
Created attachment 350660 [details] Patch
Wendy
Comment 12 2018-09-24 13:37:10 PDT
Created attachment 350677 [details] Patch
youenn fablet
Comment 13 2018-09-24 21:27:13 PDT
Comment on attachment 350677 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=350677&action=review > LayoutTests/imported/w3c/ChangeLog:14 > + * web-platform-tests/mst-content-hint/w3c-import.log: Added. The change log is not right here. It should only contain the following line: * imported/w3c/web-platform-tests/mst-content-hint/idlharness.window-expected.txt
Wendy
Comment 14 2018-09-25 11:04:04 PDT
Created attachment 350763 [details] Patch
WebKit Commit Bot
Comment 15 2018-09-25 11:55:33 PDT
Comment on attachment 350763 [details] Patch Clearing flags on attachment: 350763 Committed r236467: <https://trac.webkit.org/changeset/236467>
WebKit Commit Bot
Comment 16 2018-09-25 11:55:35 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.