Bug 189850

Summary: Deprecate ObjC SPI in Deprecated Xcode group
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch aestes: review+

Description Alex Christensen 2018-09-21 12:32:39 PDT
Deprecate ObjC SPI in Deprecated Xcode group
Comment 1 Alex Christensen 2018-09-21 14:03:30 PDT
Created attachment 350420 [details]
Patch
Comment 2 Alex Christensen 2018-09-24 16:38:31 PDT
Created attachment 350710 [details]
Patch
Comment 3 Alex Christensen 2018-09-24 17:05:34 PDT
Created attachment 350712 [details]
Patch
Comment 4 Alex Christensen 2018-09-24 22:49:10 PDT
Created attachment 350739 [details]
Patch
Comment 5 Andy Estes 2018-09-27 15:16:45 PDT
Comment on attachment 350739 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=350739&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKBrowsingContextGroup.h:33
> -WK_CLASS_AVAILABLE(macosx(10.10), ios(8.0))
> +WK_CLASS_DEPRECATED_WITH_REPLACEMENT("WKUserContentController", macos(10.10, WK_MAC_TBA), ios(8.0, WK_IOS_TBA))

Seems like this was a weird mix of user content and preferences. I guess there is no single replacement in the modern API; should you mention WKPreferences as well?
Comment 6 Alex Christensen 2018-10-01 10:17:07 PDT
http://trac.webkit.org/r236665
Comment 7 Radar WebKit Bug Importer 2018-10-01 10:18:22 PDT
<rdar://problem/44912137>
Comment 8 Alex Christensen 2018-10-01 11:27:44 PDT
http://trac.webkit.org/r236675
Comment 9 Alex Christensen 2018-10-01 12:58:02 PDT
http://trac.webkit.org/r236687