Bug 189843

Summary:

[MediaStream] Add mock window capture source

Product:

WebKit

Reporter:

Eric Carlson <eric.carlson>

Component:

WebRTC

Assignee:

Eric Carlson <eric.carlson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, ews-watchlist, rniwa, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Archive of layout-test-results from ews106 for mac-sierra-wk2	none
Patch	none
Patch for landing	none

Eric Carlson

Reported 2018-09-21 11:42:17 PDT

Add Mac and mock window capture sources

Attachments
Patch (66.56 KB, patch) 2018-09-22 19:02 PDT, Eric Carlson	no flags	Details Formatted Diff Diff
Patch (66.65 KB, patch) 2018-09-23 09:15 PDT, Eric Carlson	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews106 for mac-sierra-wk2 (3.05 MB, application/zip) 2018-09-23 12:38 PDT, EWS Watchlist	no flags	Details
Patch (16.14 KB, patch) 2018-09-24 12:25 PDT, Eric Carlson	no flags	Details Formatted Diff Diff
Patch for landing (16.47 KB, patch) 2018-09-24 12:53 PDT, Eric Carlson	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2018-09-21 11:42:52 PDT

<rdar://problem/44687445>

Eric Carlson

Comment 2 2018-09-22 19:02:18 PDT

Created attachment 350541 [details] Patch

EWS Watchlist

Comment 3 2018-09-22 19:04:22 PDT

Attachment 350541 [details] did not pass style-queue: ERROR: Source/WebCore/platform/mediastream/mac/WindowDisplayCaptureSourceMac.mm:43: *SoftLink.h header should be included after all other headers. [build/include_order] [4] Total errors found: 1 in 24 files If any of these errors are false positives, please file a bug against check-webkit-style.

Eric Carlson

Comment 4 2018-09-23 09:15:24 PDT

Created attachment 350569 [details] Patch

EWS Watchlist

Comment 5 2018-09-23 12:38:00 PDT

Comment on attachment 350569 [details] Patch Attachment 350569 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/9322641 New failing tests: http/tests/media/media-stream/get-display-media-prompt.html

EWS Watchlist

Comment 6 2018-09-23 12:38:01 PDT

Created attachment 350583 [details] Archive of layout-test-results from ews106 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

Eric Carlson

Comment 7 2018-09-24 12:25:24 PDT

Created attachment 350664 [details] Patch

youenn fablet

Comment 8 2018-09-24 12:31:09 PDT

Comment on attachment 350664 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=350664&action=review > Source/WebCore/platform/mock/MockRealtimeVideoSource.cpp:142 > + return RealtimeMediaSource::supportsSizeAndFrameRate(width, height, rate); That seems a bit odd here and below, Is there a way to improve things here?

Eric Carlson

Comment 9 2018-09-24 12:53:58 PDT

Created attachment 350671 [details] Patch for landing

WebKit Commit Bot

Comment 10 2018-09-24 13:13:04 PDT

Comment on attachment 350671 [details] Patch for landing Clearing flags on attachment: 350671 Committed r236422: <https://trac.webkit.org/changeset/236422>

WebKit Commit Bot

Comment 11 2018-09-24 13:13:05 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.