Bug 18984

Summary: [GTK] textarea height property works only if other property are defined
Product: WebKit Reporter: arno. <a.renevier>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: jmalonzo, plaes
Priority: P2 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
testcase
none
patch gustavo: review+

arno.
Reported 2008-05-10 03:16:40 PDT
Hi, When you set height property to a textarea, it is not taken into account. To make height property work, you must set other properties, such as border, or background-color.
Attachments
testcase (309 bytes, text/html)
2008-05-10 03:17 PDT, arno. 		no flags
Details
patch (3.19 KB, patch)
2009-07-07 08:18 PDT, Jan Alonzo 		gustavo: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
arno.
Comment 1 2008-05-10 03:17:50 PDT
Created attachment 21055 [details] testcase
Dirk Schulze
Comment 2 2008-05-10 03:58:55 PDT
The same here. But it is only related to WebKitGtk. Changed the report.
Jan Alonzo
Comment 3 2009-07-07 08:18:22 PDT
Created attachment 32378 [details] patch
Gustavo Noronha (kov)
Comment 4 2009-07-07 08:35:12 PDT
Comment on attachment 32378 [details] patch Thanks for looking into this! It makes me sad =). I believe leaving this for webcore to do is not really what we want; we probably want to do the same as adjustTextFieldStyle, except for setting the height to auto. I'll say r- on that basis.
Gustavo Noronha (kov)
Comment 5 2009-07-07 08:44:16 PDT
Comment on attachment 32378 [details] patch After clarifying a few concerns with Jan regarding the effect this had in things such as dark themes, I now believe this is correct, so I'll say r=me.
Jan Alonzo
Comment 6 2009-07-07 08:53:10 PDT
(In reply to comment #5) > (From update of attachment 32378 [details]) > After clarifying a few concerns with Jan regarding the effect this had in > things such as dark themes, I now believe this is correct, so I'll say r=me. Thanks. Landed in r45595.
Note You need to log in before you can comment on or make changes to this bug.