Bug 189831

Summary: [ARM] Build broken on armv7hl after r235517
Product: WebKit Reporter: Tomas Popela <tpopela>
Component: JavaScriptCoreAssignee: Tomas Popela <tpopela>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Tomas Popela
Reported 2018-09-21 07:25:55 PDT
It's broken because of the missing implementation of patchableBranch8(). Fro ARMV7 it was added by Mark in https://trac.webkit.org/r235557, but the implementation for traditional ARM is still missing.
Attachments
Patch (1.74 KB, patch)
2018-09-21 07:27 PDT, Tomas Popela 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tomas Popela
Comment 1 2018-09-21 07:27:32 PDT
Created attachment 350359 [details] Patch
Yusuke Suzuki
Comment 2 2018-09-21 07:30:42 PDT
Comment on attachment 350359 [details] Patch r=me as a build fix.
Tomas Popela
Comment 3 2018-09-21 07:35:45 PDT
Comment on attachment 350359 [details] Patch Clearing flags on attachment: 350359 Committed r236315: <https://trac.webkit.org/changeset/236315>
Tomas Popela
Comment 4 2018-09-21 07:35:50 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2018-09-21 07:36:20 PDT
<rdar://problem/44679245>
Note You need to log in before you can comment on or make changes to this bug.