Bug 189823

Summary: TransformationMatrix::toColumnMajorFloatArray() should return a std::array<> object
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, ews-watchlist, kondapallykalyan, luiz, mcatanzaro, noam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Zan Dobersek
Reported 2018-09-21 03:09:42 PDT
TransformationMatrix::toColumnMajorFloatArray() should return a std::array<> object
Attachments
Patch (6.54 KB, patch)
2018-09-21 03:12 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch (6.54 KB, patch)
2018-09-21 04:05 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2018-09-21 03:12:08 PDT
Created attachment 350345 [details] Patch
Zan Dobersek
Comment 2 2018-09-21 04:05:35 PDT
Created attachment 350348 [details] Patch
Michael Catanzaro
Comment 3 2018-09-21 04:27:01 PDT
Comment on attachment 350348 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=350348&action=review > Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp:1727 > -void TransformationMatrix::toColumnMajorFloatArray(FloatMatrix4& result) const > +auto TransformationMatrix::toColumnMajorFloatArray() const -> FloatMatrix4 Wow, a good use of the trailing return syntax...
Zan Dobersek
Comment 4 2018-09-21 05:47:47 PDT
Comment on attachment 350348 [details] Patch Clearing flags on attachment: 350348 Committed r236311: <https://trac.webkit.org/changeset/236311>
Zan Dobersek
Comment 5 2018-09-21 05:47:51 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2018-09-21 05:48:23 PDT
<rdar://problem/44677771>
Note You need to log in before you can comment on or make changes to this bug.