Bug 189819

Summary: Implement initialValue support for CSS Custom Properties and Values API
Product: WebKit Reporter: Justin Michaud <justin_michaud>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, dino, ews-watchlist, rniwa, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 189692    
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews200 for win-future
none
Patch
none
Patch none

Justin Michaud
Reported 2018-09-20 22:44:17 PDT
Support setting initialValue for custom properties
Attachments
Patch (36.36 KB, patch)
2018-09-20 22:51 PDT, Justin Michaud 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews200 for win-future (13.05 MB, application/zip)
2018-09-21 02:57 PDT, EWS Watchlist 		no flags
Details
Patch (37.00 KB, patch)
2018-09-21 16:58 PDT, Justin Michaud 		no flags
DetailsFormatted DiffDiff
Patch (37.12 KB, patch)
2018-09-21 17:21 PDT, Justin Michaud 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Justin Michaud
Comment 1 2018-09-20 22:51:41 PDT
Created attachment 350331 [details] Patch
EWS Watchlist
Comment 2 2018-09-21 02:57:01 PDT
Comment on attachment 350331 [details] Patch Attachment 350331 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/9293702 New failing tests: css-custom-properties-api/initialValue.html css-custom-properties-api/initialValueJS.html
EWS Watchlist
Comment 3 2018-09-21 02:57:13 PDT
Created attachment 350344 [details] Archive of layout-test-results from ews200 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews200 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Justin Michaud
Comment 4 2018-09-21 16:58:45 PDT
Created attachment 350456 [details] Patch
Justin Michaud
Comment 5 2018-09-21 17:21:40 PDT
Created attachment 350461 [details] Patch
WebKit Commit Bot
Comment 6 2018-09-21 18:03:57 PDT
Comment on attachment 350461 [details] Patch Clearing flags on attachment: 350461 Committed r236379: <https://trac.webkit.org/changeset/236379>
WebKit Commit Bot
Comment 7 2018-09-21 18:04:00 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2018-09-21 18:05:07 PDT
<rdar://problem/44698845>
Ryosuke Niwa
Comment 9 2018-09-21 19:53:13 PDT
Comment on attachment 350461 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=350461&action=review > Source/WebCore/css/CSSRegisteredCustomProperty.h:40 > +using CSSRegisteredCustomPropertySet = HashMap<String, std::unique_ptr<CSSRegisteredCustomProperty>>; It's weird to call HashMap a set. We should probably rename this to CSSRegisteredCustomPropertyMap.
Note You need to log in before you can comment on or make changes to this bug.