Bug 189815
| Summary: | check-webkit-style complains about weird indentation when line has leading C-style comment | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Daniel Bates <dbates> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | aakash_jain, dean_johnson, jbedard, lforschler |
| Priority: | P2 | ||
| Version: | WebKit Local Build | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=189604 | ||
Daniel Bates
Consider the following code:
0. int windowsKeyCodeForKeyCode(uint16_t keyCode)
1. {
2. static const int windowsKeyCode[] = {
3. /* 0 */ VK_A,
4. }
5. return 0;
6. }
check-webkit-style complains that line 3 has a "Weird number of spaces at line-start. Are you using a 4-space indent?" even though the start of the C-style comment is on a 4 space boundary.
Compare the behavior to this code:
0. int windowsKeyCodeForKeyCode(uint16_t keyCode)
1. {
2. static const int windowsKeyCode[] = {
3. VK_A,
4. }
5. return 0;
6. }
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Daniel Bates
I hit this issue when running check-webkit-style against attachment #350311 [details] (bug #189604).