| Summary: | Restrict the total combined size of backdrop filters | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dean Jackson <dino> | ||||
| Component: | New Bugs | Assignee: | Dean Jackson <dino> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | ews-watchlist, mitz, simon.fraser, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Dean Jackson
2018-09-20 18:12:28 PDT
Created attachment 350296 [details]
Patch
Comment on attachment 350296 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=350296&action=review > Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:1591 > + if (commitState.totalBackdropFilterSize != childCommitState.totalBackdropFilterSize) What happens if you delete this line? Comment on attachment 350296 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=350296&action=review > Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:95 > +static const unsigned cMaxTotalBackdropFilterSize = 1242 * 2208 * 10; Maybe call this "area" > Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h:158 > + unsigned totalBackdropFilterSize { 0 }; totalBackdropFilterArea Comment on attachment 350296 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=350296&action=review >> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:1591 >> + if (commitState.totalBackdropFilterSize != childCommitState.totalBackdropFilterSize) > > What happens if you delete this line? This is the best review comment I've ever received. Committed r236306: <https://trac.webkit.org/changeset/236306> |