Bug 189804

Summary:

Move IOKitSPI.h from TestRunnerShared to PAL

Product:

WebKit

Reporter:

Daniel Bates <dbates>

Component:

Platform

Assignee:

Daniel Bates <dbates>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

jeremyj-wk, simon.fraser, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

190571, 189604

Attachments:

Description	Flags
Patch	none

Description Daniel Bates 2018-09-20 15:08:23 PDT

Towards fixing bug #189604 move the IOKit SPI forward declarations to PAL so that they can be shared by code in WebKit, DumpRenderTree and WebKitTestRunner.

Comment 1 Daniel Bates 2018-09-20 15:10:58 PDT

Created attachment 350269 [details]
Patch

Comment 2 Daniel Bates 2018-09-20 15:12:35 PDT

I made one change to IOKitSPI.h when moving it. I removed the "#import <wtf/Platform.h>" statement as this is not needed given our use of prefix headers.

Comment 3 Daniel Bates 2018-09-20 20:15:41 PDT

Comment on attachment 350269 [details]
Patch

Clearing flags on attachment: 350269

Committed r236303: <https://trac.webkit.org/changeset/236303>

Comment 4 Daniel Bates 2018-09-20 20:15:43 PDT

All reviewed patches have been landed.  Closing bug.

Comment 5 Radar WebKit Bug Importer 2018-09-20 20:16:38 PDT

<rdar://problem/44666336>