Bug 189795

Summary:

[WHLSL] Metal code generation for samplers and textures

Product:

WebKit

Reporter:

Thomas Denney <tdenney>

Component:

WebGPU

Assignee:

Thomas Denney <tdenney>

Status:

RESOLVED MOVED

Severity:

Normal

CC:

dino, ews-watchlist, mmaxfield

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

187735

Bug Blocks:

176199, 189202

Attachments:

Description	Flags
WIP	none

Thomas Denney

Reported 2018-09-20 10:48:01 PDT

Currently the sampler and texture types and functions are unimplemented. However, there should be a 1:1 mapping with WHLSL/MSL functions so this shouldn’t take too long.

Attachments
WIP (357.91 KB, patch) 2018-09-22 02:23 PDT, Thomas Denney	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Thomas Denney

Comment 1 2018-09-22 02:23:47 PDT

Created attachment 350508 [details] WIP

EWS Watchlist

Comment 2 2018-09-22 02:27:50 PDT

Attachment 350508 [details] did not pass style-queue: ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.m:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL ToyTests/WHLSL_ToyTests.m:28: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OffscreenRenderer.m:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestDescription.m:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.h:29: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.h:27: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL Tests.xcodeproj/project.pbxproj:790: developmentRegion is not English. [xcodeproj/settings] [5] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestCallArgument.m:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CustomMetalView.m:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.m:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CompileResult.m:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/AppDelegate.m:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/Renderer.m:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.h:27: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OnscreenRenderer.h:28: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OnscreenRenderer.m:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 18 in 43 files If any of these errors are false positives, please file a bug against check-webkit-style.

Myles C. Maxfield

Comment 3 2018-10-13 14:23:21 PDT

Migrated to https://api.github.com/repos/gpuweb/WHLSL/issues/32

Myles C. Maxfield

Comment 4 2018-10-13 14:53:31 PDT

https://github.com/gpuweb/WHLSL/issues/32

Note You need to log in before you can comment on or make changes to this bug.