Bug 189777

Summary:

Use a Variant for FormDataElement

Product:

WebKit

Reporter:

Alex Christensen <achristensen>

Component:

New Bugs

Assignee:

Alex Christensen <achristensen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aestes, berto, cdumez, cgarcia, ews-watchlist, galpeter, gustavo, joepeck, mcatanzaro, rniwa, thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews102 for mac-sierra	none
Archive of layout-test-results from ews106 for mac-sierra-wk2	none
Archive of layout-test-results from ews117 for mac-sierra	none
Archive of layout-test-results from ews121 for ios-simulator-wk2	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Archive of layout-test-results from ews123 for ios-simulator-wk2	none
Archive of layout-test-results from ews107 for mac-sierra-wk2	none
Archive of layout-test-results from ews125 for ios-simulator-wk2	none
Patch	none
Patch	none
Patch	none

Alex Christensen

Reported Thursday, September 20, 2018 6:13:45 AM UTC

Use a Variant for FormDataElement

Attachments
Patch (41.08 KB, patch) 2018-09-19 22:14 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews102 for mac-sierra (2.09 MB, application/zip) 2018-09-19 23:13 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews106 for mac-sierra-wk2 (2.61 MB, application/zip) 2018-09-19 23:25 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews117 for mac-sierra (1.32 MB, application/zip) 2018-09-19 23:39 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews121 for ios-simulator-wk2 (76.24 MB, application/zip) 2018-09-19 23:59 PDT, EWS Watchlist	no flags	Details
Patch (42.53 KB, patch) 2018-09-20 11:47 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (45.48 KB, patch) 2018-09-20 12:09 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (45.47 KB, patch) 2018-09-20 12:18 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (45.49 KB, patch) 2018-09-20 12:46 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (45.53 KB, patch) 2018-09-20 13:59 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (45.42 KB, patch) 2018-09-20 15:24 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (47.83 KB, patch) 2018-09-20 17:22 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (47.85 KB, patch) 2018-09-20 18:33 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews123 for ios-simulator-wk2 (21.77 MB, application/zip) 2018-09-20 20:45 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews107 for mac-sierra-wk2 (3.57 MB, application/zip) 2018-09-20 21:21 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews125 for ios-simulator-wk2 (19.43 MB, application/zip) 2018-09-20 22:46 PDT, EWS Watchlist	no flags	Details
Patch (47.51 KB, patch) 2018-09-20 23:32 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (49.34 KB, patch) 2018-09-21 14:17 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (49.32 KB, patch) 2018-09-21 14:42 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Show Obsolete (18) View All Add attachment proposed patch, testcase, etc.

Alex Christensen

Comment 1 Thursday, September 20, 2018 6:14:26 AM UTC

Created attachment 350169 [details] Patch

EWS Watchlist

Comment 2 Thursday, September 20, 2018 7:13:36 AM UTC

Comment on attachment 350169 [details] Patch Attachment 350169 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/9277810 Number of test failures exceeded the failure limit.

EWS Watchlist

Comment 3 Thursday, September 20, 2018 7:13:38 AM UTC

Created attachment 350171 [details] Archive of layout-test-results from ews102 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 4 Thursday, September 20, 2018 7:25:57 AM UTC

Comment on attachment 350169 [details] Patch Attachment 350169 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/9277821 Number of test failures exceeded the failure limit.

EWS Watchlist

Comment 5 Thursday, September 20, 2018 7:25:58 AM UTC

Created attachment 350173 [details] Archive of layout-test-results from ews106 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 6 Thursday, September 20, 2018 7:39:19 AM UTC

Comment on attachment 350169 [details] Patch Attachment 350169 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/9277814 Number of test failures exceeded the failure limit.

EWS Watchlist

Comment 7 Thursday, September 20, 2018 7:39:21 AM UTC

Created attachment 350176 [details] Archive of layout-test-results from ews117 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 8 Thursday, September 20, 2018 7:59:02 AM UTC

Comment on attachment 350169 [details] Patch Attachment 350169 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/9277857 Number of test failures exceeded the failure limit.

EWS Watchlist

Comment 9 Thursday, September 20, 2018 7:59:06 AM UTC

Created attachment 350177 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6

Alex Christensen

Comment 10 Thursday, September 20, 2018 7:47:54 PM UTC

Created attachment 350240 [details] Patch

Alex Christensen

Comment 11 Thursday, September 20, 2018 8:09:00 PM UTC

Created attachment 350245 [details] Patch

Alex Christensen

Comment 12 Thursday, September 20, 2018 8:18:09 PM UTC

Created attachment 350246 [details] Patch

Alex Christensen

Comment 13 Thursday, September 20, 2018 8:46:49 PM UTC

Created attachment 350249 [details] Patch

Alex Christensen

Comment 14 Thursday, September 20, 2018 9:59:34 PM UTC

Created attachment 350260 [details] Patch

Alex Christensen

Comment 15 Thursday, September 20, 2018 11:24:59 PM UTC

Created attachment 350270 [details] Patch

Alex Christensen

Comment 16 Friday, September 21, 2018 1:22:02 AM UTC

Created attachment 350285 [details] Patch

Alex Christensen

Comment 17 Friday, September 21, 2018 2:33:56 AM UTC

Created attachment 350299 [details] Patch

EWS Watchlist

Comment 18 Friday, September 21, 2018 4:45:50 AM UTC

Comment on attachment 350299 [details] Patch Attachment 350299 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/9290636 New failing tests: http/tests/local/formdata/send-form-data-constructed-from-form-using-open-panel.html http/tests/local/formdata/send-form-data-with-empty-file-filename-using-open-panel.html

EWS Watchlist

Comment 19 Friday, September 21, 2018 4:45:53 AM UTC

Created attachment 350318 [details] Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 20 Friday, September 21, 2018 5:21:28 AM UTC

Comment on attachment 350299 [details] Patch Attachment 350299 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/9291283 New failing tests: http/tests/local/formdata/send-form-data-constructed-from-form-using-open-panel.html http/tests/local/formdata/send-form-data-with-empty-file-filename-using-open-panel.html

EWS Watchlist

Comment 21 Friday, September 21, 2018 5:21:30 AM UTC

Created attachment 350324 [details] Archive of layout-test-results from ews107 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 22 Friday, September 21, 2018 6:46:13 AM UTC

Comment on attachment 350299 [details] Patch Attachment 350299 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/9291812 New failing tests: http/tests/local/formdata/send-form-data-constructed-from-form-using-open-panel.html http/tests/local/formdata/send-form-data-with-empty-file-filename-using-open-panel.html

EWS Watchlist

Comment 23 Friday, September 21, 2018 6:46:16 AM UTC

Created attachment 350330 [details] Archive of layout-test-results from ews125 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6

Alex Christensen

Comment 24 Friday, September 21, 2018 7:32:00 AM UTC

Created attachment 350335 [details] Patch

Chris Dumez

Comment 25 Friday, September 21, 2018 10:09:10 PM UTC

Comment on attachment 350335 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=350335&action=review r=me > Source/WebCore/platform/network/FormData.cpp:142 > + return WTF::visit(WTF::makeVisitor( SwitchOn() ? > Source/WebCore/platform/network/FormData.cpp:160 > + return WTF::visit(WTF::makeVisitor( SwitchOn() ? > Source/WebCore/platform/network/FormData.cpp:358 > + WTF::visit(WTF::makeVisitor( SwitchOn() ? > Source/WebCore/platform/network/FormData.h:44 > + FormDataElement(Data&& data) Why isn't this explicit ? > Source/WebCore/platform/network/FormData.h:75 > + bool shouldGenerateFile { false }; Can we pack this better and move all booleans to the end? > Source/WebCore/platform/network/cf/FormDataStreamCFNet.cpp:139 > + bool success = WTF::visit(WTF::makeVisitor( SwitchOn() ? > Source/WebCore/platform/network/curl/CurlFormDataStream.cpp:127 > + std::optional<size_t> readBytes = WTF::visit(WTF::makeVisitor( SwitchOn() ? > Source/WebCore/platform/network/soup/ResourceRequestSoup.cpp:77 > + return WTF::visit(WTF::makeVisitor( SwitchOn() ? > Source/WebKit/WebProcess/WebCoreSupport/SessionStateConversion.cpp:45 > + WTF::visit(WTF::makeVisitor( SwitchOn() ?

Alex Christensen

Comment 26 Friday, September 21, 2018 10:17:50 PM UTC

Created attachment 350428 [details] Patch

Alex Christensen

Comment 27 Friday, September 21, 2018 10:42:14 PM UTC

Created attachment 350430 [details] Patch

Alex Christensen

Comment 28 Friday, September 21, 2018 11:50:48 PM UTC

http://trac.webkit.org/r236365

Radar WebKit Bug Importer

Comment 29 Friday, September 21, 2018 11:52:11 PM UTC

<rdar://problem/44695354>

Note You need to log in before you can comment on or make changes to this bug.