Bug 189774

Summary: Adopt safe-area-inset on ImageDocument
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: New BugsAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, esprehn+autocc, ews-watchlist, gyuyoung.kim, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Benjamin Poulain
Reported 2018-09-19 20:09:45 PDT
Adopt safe-area-instead on ImageDocument
Attachments
Patch (3.27 KB, patch)
2018-09-19 20:13 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Patch (3.26 KB, patch)
2018-09-20 14:10 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2018-09-19 20:13:15 PDT
Created attachment 350166 [details] Patch
Benjamin Poulain
Comment 2 2018-09-19 20:13:17 PDT
<rdar://problem/44624432>
Benjamin Poulain
Comment 3 2018-09-19 20:15:53 PDT
Hopefully I am not too rusty for WebKit patches :)
Tim Horton
Comment 4 2018-09-19 20:36:17 PDT
Comment on attachment 350166 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=350166&action=review > Source/WebCore/ChangeLog:8 > + rdar://problem/44624432 People usually put this up on the line immediately below the bugzilla link. Unless you're being weird on purpose like Beth. > Source/WebCore/html/ImageDocument.cpp:236 > + imageElement->setAttribute(styleAttr, "-webkit-user-select:none; display:block; margin:auto; padding:env(safe-area-inset-top) env(safe-area-inset-right) env(safe-area-inset-bottom) env(safe-area-inset-left)"); Trailing semicolons like we had before? Doesn't really matter. > Source/WebCore/html/ImageDocument.cpp:238 > + imageElement->setAttribute(styleAttr, "-webkit-user-select:none; padding:env(safe-area-inset-top) env(safe-area-inset-right) env(safe-area-inset-bottom) env(safe-area-inset-left)"); I wish I had added a shorthand for this :P
Benjamin Poulain
Comment 5 2018-09-20 14:10:04 PDT
Created attachment 350261 [details] Patch
Benjamin Poulain
Comment 6 2018-09-20 14:10:39 PDT
(In reply to Tim Horton from comment #4) > Comment on attachment 350166 [details] > Patch > [...] Thank you for the quick review Tim!
WebKit Commit Bot
Comment 7 2018-09-20 16:12:07 PDT
Comment on attachment 350261 [details] Patch Clearing flags on attachment: 350261 Committed r236290: <https://trac.webkit.org/changeset/236290>
WebKit Commit Bot
Comment 8 2018-09-20 16:12:08 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.