Bug 189767

Summary: [WebVTT] Update the parser according to the new region syntax.
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: MediaAssignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: ahmad.saleem792, bfulgham, commit-queue, eric.carlson, webkit-bug-importer, zcorpan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
eric.carlson: review+
Patch
none
Patch none

Per Arne Vollan
Reported 2018-09-19 15:55:43 PDT
The syntax of WebVTT region declarations has changed. The previous declaration style can be found in https://www.w3.org/2013/07/webvtt.html. The new style is defined in https://w3c.github.io/webvtt/. Example of the new syntax: REGION id=region_floating_point_anchor regionanchor=41.133%,20.42% viewportanchor=32.33%,32.44% This is how this would have been written using the old syntax: Region: id=region_floating_point_anchor regionanchor=41.133%,20.42% viewportanchor=32.33%,32.44%
Attachments
Patch (14.02 KB, patch)
2018-09-19 16:27 PDT, Per Arne Vollan 		eric.carlson: review+
DetailsFormatted DiffDiff
Patch (14.00 KB, patch)
2018-09-20 08:42 PDT, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Patch (14.04 KB, patch)
2018-09-20 09:32 PDT, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Per Arne Vollan
Comment 1 2018-09-19 16:27:56 PDT
Created attachment 350158 [details] Patch
Radar WebKit Bug Importer
Comment 2 2018-09-19 16:28:33 PDT
<rdar://problem/44621597>
Per Arne Vollan
Comment 3 2018-09-20 08:42:55 PDT
Created attachment 350206 [details] Patch
Per Arne Vollan
Comment 4 2018-09-20 09:32:32 PDT
Created attachment 350217 [details] Patch
WebKit Commit Bot
Comment 5 2018-09-20 10:07:11 PDT
Comment on attachment 350217 [details] Patch Clearing flags on attachment: 350217 Committed r236265: <https://trac.webkit.org/changeset/236265>
Simon Pieters (:zcorpan)
Comment 6 2018-10-04 08:06:51 PDT
(In reply to Per Arne Vollan from comment #0) > Example of the new syntax: > > REGION > id=region_floating_point_anchor > regionanchor=41.133%,20.42% > viewportanchor=32.33%,32.44% The = should be :
Ahmad Saleem
Comment 7 2023-09-08 15:42:22 PDT
Landed: https://github.com/WebKit/WebKit/commit/26669c3d46a0b67d07ab8197299dbce49f16ab47 and didn't seem to back out. Marking this as 'RESOLVED FIXED'.
Note You need to log in before you can comment on or make changes to this bug.