| Summary: | Import WPT tests for css custom properties api | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Justin Michaud <justin_michaud> | ||||||||||
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | bfulgham, commit-queue, dino, ews-watchlist, rniwa, simon.fraser, webkit-bug-importer, zalan | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Bug Depends on: | |||||||||||||
| Bug Blocks: | 189692 | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Justin Michaud
2018-09-19 13:38:53 PDT
Created attachment 350478 [details]
Patch
Comment on attachment 350478 [details] Patch Attachment 350478 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/9307265 New failing tests: imported/w3c/web-platform-tests/css/css-properties-values-api/var-reference-registered-properties.html imported/w3c/web-platform-tests/css/css-properties-values-api/registered-property-initial.html imported/w3c/web-platform-tests/css/css-properties-values-api/var-reference-registered-properties-cycles.html imported/w3c/web-platform-tests/css/css-properties-values-api/property-cascade.html imported/w3c/web-platform-tests/css/css-properties-values-api/typedom.tentative.html imported/w3c/web-platform-tests/css/css-properties-values-api/registered-properties-inheritance.html imported/w3c/web-platform-tests/css/css-properties-values-api/unit-cycles.html imported/w3c/web-platform-tests/css/css-properties-values-api/url-resolution.html imported/w3c/web-platform-tests/css/css-properties-values-api/registered-property-computation.html imported/w3c/web-platform-tests/css/css-properties-values-api/register-property.html imported/w3c/web-platform-tests/css/css-properties-values-api/register-property-syntax-parsing.html imported/w3c/web-platform-tests/css/css-properties-values-api/registered-property-cssom.html Created attachment 350485 [details]
Archive of layout-test-results from ews100 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 350478 [details] Patch Attachment 350478 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/9307378 New failing tests: imported/w3c/web-platform-tests/css/css-properties-values-api/var-reference-registered-properties.html imported/w3c/web-platform-tests/css/css-properties-values-api/registered-property-initial.html imported/w3c/web-platform-tests/css/css-properties-values-api/registered-properties-inheritance.html imported/w3c/web-platform-tests/css/css-properties-values-api/property-cascade.html imported/w3c/web-platform-tests/css/css-properties-values-api/typedom.tentative.html imported/w3c/web-platform-tests/css/css-properties-values-api/var-reference-registered-properties-cycles.html imported/w3c/web-platform-tests/css/css-properties-values-api/unit-cycles.html imported/w3c/web-platform-tests/css/css-properties-values-api/url-resolution.html imported/w3c/web-platform-tests/css/css-properties-values-api/registered-property-computation.html imported/w3c/web-platform-tests/css/css-properties-values-api/register-property.html imported/w3c/web-platform-tests/css/css-properties-values-api/register-property-syntax-parsing.html imported/w3c/web-platform-tests/css/css-properties-values-api/registered-property-cssom.html Created attachment 350495 [details]
Archive of layout-test-results from ews117 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117 Port: mac-sierra Platform: Mac OS X 10.12.6
Created attachment 350685 [details]
Patch
Comment on attachment 350685 [details]
Patch
Is this feature somehow enabled in WebKitTestRunner by default?
Yes. Dean confirmed that for web platform tests, experimental features are enabled by default. We still need the header comment for regular tests though, as far as I know. Also, it doesn't work for webkit 1, which is why I changed the test expectation. Comment on attachment 350685 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=350685&action=review r=me > LayoutTests/platform/mac-wk1/TestExpectations:625 > +imported/w3c/web-platform-tests/css/css-properties-values-api/ [ Skip ] > css-custom-properties-api [ Skip ] Why is this feature not supported on WK1? That seems like a weird discrepancy. We certainly shouldn't ship this feature only to WK2. It should work in WK1, but the feature flag is not supported because it required a bunch of manual changes to get it to work with the test runner. It didn't seem like it was worth the effort when I was talking with Dean and Simon, at least for now. Comment on attachment 350685 [details] Patch Clearing flags on attachment: 350685 Committed r236444: <https://trac.webkit.org/changeset/236444> All reviewed patches have been landed. Closing bug. |