Bug 189748

Summary: Garbled rendering of image when applied feConvolveMatrix to it, on Retina display
Product: WebKit Reporter: nitrino
Component: SVGAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, ews-watchlist, jonlee, kondapallykalyan, sabouhallawa, simon.fraser, webkit-bug-importer, zimmermann
Priority: P2 Keywords: InRadar
Version: Safari 11   
Hardware: All   
OS: All   
URL: https://codepen.io/mark-tyler/pen/VGqbbe
Attachments:
Description Flags
Video showing bug
none
Patch none

nitrino
Reported 2018-09-19 06:26:17 PDT
Created attachment 350109 [details] Video showing bug Here is test case: https://codepen.io/mark-tyler/pen/VGqbbe Works fine in Chrome, but Safari (iPhone or OSX), renders totally garbled image.
Attachments
Video showing bug (1.32 MB, video/mp4)
2018-09-19 06:26 PDT, nitrino
no flags
Patch (3.83 KB, patch)
2018-09-23 11:11 PDT, Simon Fraser (smfr)
no flags
Radar WebKit Bug Importer
Comment 1 2018-09-19 16:24:39 PDT
Simon Fraser (smfr)
Comment 2 2018-09-19 16:51:21 PDT
Similar to bug 188486.
Simon Fraser (smfr)
Comment 3 2018-09-19 16:53:02 PDT
Only happens on Retina displays.
Simon Fraser (smfr)
Comment 4 2018-09-20 22:03:22 PDT
diff --git a/Source/WebCore/platform/graphics/filters/FEConvolveMatrix.cpp b/Source/WebCore/platform/graphics/filters/FEConvolveMatrix.cpp index bea66fbf6bea5a35df7e020b7015ba71e9e00536..674b3aaf8a0fac0381578218df675242a841412e 100644 --- a/Source/WebCore/platform/graphics/filters/FEConvolveMatrix.cpp +++ b/Source/WebCore/platform/graphics/filters/FEConvolveMatrix.cpp @@ -391,6 +391,8 @@ void FEConvolveMatrix::platformApplySoftware() return; IntSize paintSize = absolutePaintRect().size(); + paintSize.scale(filter().filterScale()); + PaintingData paintingData = { *srcPixelArray, *resultImage,
Simon Fraser (smfr)
Comment 5 2018-09-23 11:11:20 PDT
WebKit Commit Bot
Comment 6 2018-09-24 11:00:40 PDT
Comment on attachment 350574 [details] Patch Clearing flags on attachment: 350574 Committed r236412: <https://trac.webkit.org/changeset/236412>
WebKit Commit Bot
Comment 7 2018-09-24 11:00:41 PDT
All reviewed patches have been landed. Closing bug.
nitrino
Comment 8 2018-09-25 06:44:10 PDT
Thanks! any thoughts on when this may be released in Safari on OSX?
Simon Fraser (smfr)
Comment 9 2018-09-25 10:24:45 PDT
(In reply to nitrino from comment #8) > Thanks! any thoughts on when this may be released in Safari on OSX? I can't say, but I can tell you that the fix will be in a Safari Tech Preview build in a couple of weeks or so.
Note You need to log in before you can comment on or make changes to this bug.