Summary: | Garbled rendering of image when applied feConvolveMatrix to it, on Retina display | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | nitrino | ||||||
Component: | SVG | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, dino, ews-watchlist, jonlee, kondapallykalyan, sabouhallawa, simon.fraser, webkit-bug-importer, zimmermann | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | Safari 11 | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
URL: | https://codepen.io/mark-tyler/pen/VGqbbe | ||||||||
Attachments: |
|
Description
nitrino
2018-09-19 06:26:17 PDT
Similar to bug 188486. Only happens on Retina displays. diff --git a/Source/WebCore/platform/graphics/filters/FEConvolveMatrix.cpp b/Source/WebCore/platform/graphics/filters/FEConvolveMatrix.cpp index bea66fbf6bea5a35df7e020b7015ba71e9e00536..674b3aaf8a0fac0381578218df675242a841412e 100644 --- a/Source/WebCore/platform/graphics/filters/FEConvolveMatrix.cpp +++ b/Source/WebCore/platform/graphics/filters/FEConvolveMatrix.cpp @@ -391,6 +391,8 @@ void FEConvolveMatrix::platformApplySoftware() return; IntSize paintSize = absolutePaintRect().size(); + paintSize.scale(filter().filterScale()); + PaintingData paintingData = { *srcPixelArray, *resultImage, Created attachment 350574 [details]
Patch
Comment on attachment 350574 [details] Patch Clearing flags on attachment: 350574 Committed r236412: <https://trac.webkit.org/changeset/236412> All reviewed patches have been landed. Closing bug. Thanks! any thoughts on when this may be released in Safari on OSX? (In reply to nitrino from comment #8) > Thanks! any thoughts on when this may be released in Safari on OSX? I can't say, but I can tell you that the fix will be in a Safari Tech Preview build in a couple of weeks or so. |