Summary: | Rename WTF_COMPILER_GCC_OR_CLANG to WTF_COMPILER_GCC_COMPATIBLE | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Fujii Hironori <Hironori.Fujii> | ||||||||
Component: | Web Template Framework | Assignee: | Fujii Hironori <Hironori.Fujii> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | achristensen, benjamin, bfulgham, cdumez, cmarcelo, dbates, dino, ews-watchlist, keith_miller, kondapallykalyan, mark.lam, mcatanzaro, msaboff, pvollan, saam, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 171618 | ||||||||||
Attachments: |
|
Description
Fujii Hironori
2018-09-18 21:48:26 PDT
Created attachment 350094 [details]
Patch
Comment on attachment 350094 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=350094&action=review > Source/WTF/ChangeLog:16 > + * wtf/Compiler.h: Replaced "COMPILER(GCC_OR_CLANG)" with "COMPILER(GCC) || COMPILER(CLANG)" of IGNORE_WARNINGS_* macros. Will we need to do this for other uses of GCC_OR_CLANG? Comment on attachment 350094 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=350094&action=review >> Source/WTF/ChangeLog:16 >> + * wtf/Compiler.h: Replaced "COMPILER(GCC_OR_CLANG)" with "COMPILER(GCC) || COMPILER(CLANG)" of IGNORE_WARNINGS_* macros. > > Will we need to do this for other uses of GCC_OR_CLANG? Just only this one because I want to enable GCC and Clang warning macros even for Clang for Windows. R? It's messed up if COMPILER(GCC_OR_CLANG) returns false when using Clang. I think we need to replace COMPILER(GCC_OR_CLANG) with something like COMPILER(GCC_COMPATIBLE). (In reply to Michael Catanzaro from comment #5) > It's messed up if COMPILER(GCC_OR_CLANG) returns false when using Clang. > > I think we need to replace COMPILER(GCC_OR_CLANG) with something like > COMPILER(GCC_COMPATIBLE). It sounds good. I will do it. Created attachment 350346 [details]
Patch
LGTM. I see the CMake COMPILER_IS_GCC_OR_CLANG is already true for Clang, so that's good. Comment on attachment 350346 [details]
Patch
Please wait one day before committing this is case anyone has other naming suggestions.
Created attachment 350728 [details]
Patch to land
Thank you for the review.
* Rebased onto Tot.
Comment on attachment 350728 [details] Patch to land Clearing flags on attachment: 350728 Committed r236450: <https://trac.webkit.org/changeset/236450> All reviewed patches have been landed. Closing bug. |