Bug 189732 – [Win][Clang] UNUSED_PARAM(this) causes compilation error of "cannot take the address of an rvalue of type"

• Component: New Bugs
• Status: RESOLVED FIXED

[Fujii Hironori]

[Win][Clang] UNUSED_PARAM(this) causes compilation error of "cannot take the address of an rvalue of type"

While doing Bug 171618, following compilation error is reported.

> [16/31] Building CXX object Source\WebKit\CMakeFiles\WebKit.dir\__\__\DerivedSources\WebKit\unified-sources\UnifiedSource22.cpp.obj
> FAILED: Source/WebKit/CMakeFiles/WebKit.dir/__/__/DerivedSources/WebKit/unified-sources/UnifiedSource22.cpp.obj 
> C:\tools\llvm\bin\clang-cl.exe (...) -c DerivedSources\WebKit\unified-sources\UnifiedSource22.cpp
> In file included from DerivedSources\WebKit\unified-sources\UnifiedSource22.cpp:5:
> ..\..\Source\WebKit\UIProcess/Network/NetworkProcessProxy.cpp(154,9):  error: cannot take the address of an rvalue of type 'WebKit::NetworkProcessProxy *'
>         UNUSED_PARAM(this);
>         ^            ~~~~
> DerivedSources\ForwardingHeaders\wtf/Compiler.h(367,38):  note: expanded from macro 'UNUSED_PARAM'
> #define UNUSED_PARAM(variable) (void)&variable
>                                      ^~~~~~~~~
> In file included from DerivedSources\WebKit\unified-sources\UnifiedSource22.cpp:5:
> ..\..\Source\WebKit\UIProcess/Network/NetworkProcessProxy.cpp(171,9):  error: cannot take the address of an rvalue of type 'WebKit::NetworkProcessProxy *'
>         UNUSED_PARAM(this);
>         ^            ~~~~
> DerivedSources\ForwardingHeaders\wtf/Compiler.h(367,38):  note: expanded from macro 'UNUSED_PARAM'
> #define UNUSED_PARAM(variable) (void)&variable
>                                      ^~~~~~~~~
> In file included from DerivedSources\WebKit\unified-sources\UnifiedSource22.cpp:5:
> ..\..\Source\WebKit\UIProcess/Network/NetworkProcessProxy.cpp(189,9):  error: cannot take the address of an rvalue of type 'WebKit::NetworkProcessProxy *'
>         UNUSED_PARAM(this);
>         ^            ~~~~
> DerivedSources\ForwardingHeaders\wtf/Compiler.h(367,38):  note: expanded from macro 'UNUSED_PARAM'
> #define UNUSED_PARAM(variable) (void)&variable
>                                      ^~~~~~~~~
> 3 errors generated.


See Also:

Bug 113440 – [WinCE] Add workaround for UNUSED_PARAM()
Bug 115350 – [WIN] Add workaround for UNUSED_PARAM()

[Fujii Hironori]

Created attachment 350092 [details]
Patch

[Fujii Hironori]

R?

[Per Arne Vollan]

Comment on attachment 350092 [details]
Patch

r=me

[Fujii Hironori]

Comment on attachment 350092 [details]
Patch

Clearing flags on attachment: 350092

Committed r236302: <https://trac.webkit.org/changeset/236302>

[Fujii Hironori]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/44665709>