Bug 189707

Summary: Implement sender/receiver getStats
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch for landing none

youenn fablet
Reported 2018-09-18 13:27:54 PDT
Implement sender/receiver getStats
Attachments
Patch (42.14 KB, patch)
2018-09-18 13:41 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (42.13 KB, patch)
2018-09-18 14:45 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (42.14 KB, patch)
2018-09-18 15:05 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2018-09-18 13:41:09 PDT
Created attachment 350045 [details] Patch
Eric Carlson
Comment 2 2018-09-18 13:49:45 PDT
Comment on attachment 350045 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=350045&action=review > Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:272 > + auto transceiver = RTCRtpTransceiver::create(RTCRtpSender::create(*this, "video", { }, WTFMove(senderBackend)), receiver.copyRef(), nullptr); Nit: "video"_s > Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:295 > + auto transceiver = RTCRtpTransceiver::create(RTCRtpSender::create(*this, "audio", { }, WTFMove(senderBackend)), receiver.copyRef(), nullptr); Nit: "audio"_s
youenn fablet
Comment 3 2018-09-18 14:45:40 PDT
Created attachment 350061 [details] Patch for landing
youenn fablet
Comment 4 2018-09-18 15:05:01 PDT
Created attachment 350064 [details] Patch for landing
WebKit Commit Bot
Comment 5 2018-09-19 08:54:16 PDT
Comment on attachment 350064 [details] Patch for landing Clearing flags on attachment: 350064 Committed r236207: <https://trac.webkit.org/changeset/236207>
WebKit Commit Bot
Comment 6 2018-09-19 08:54:17 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2018-09-19 08:55:22 PDT
<rdar://problem/44604401>
youenn fablet
Comment 8 2018-09-20 18:34:45 PDT
*** Bug 186248 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.