Bug 189707 - Implement sender/receiver getStats
Summary: Implement sender/receiver getStats
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
: 186248 (view as bug list)
Depends on:
Blocks:
 
Reported: 2018-09-18 13:27 PDT by youenn fablet
Modified: 2018-09-20 18:34 PDT (History)
4 users (show)

See Also:

Attachments
Patch (42.14 KB, patch)
2018-09-18 13:41 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (42.13 KB, patch)
2018-09-18 14:45 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (42.14 KB, patch)
2018-09-18 15:05 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2018-09-18 13:27:54 PDT 
Implement sender/receiver getStats
Comment 1 youenn fablet 2018-09-18 13:41:09 PDT 
Created attachment 350045 [details]
Patch
Comment 2 Eric Carlson 2018-09-18 13:49:45 PDT 
Comment on attachment 350045 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=350045&action=review

> Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:272
> +    auto transceiver = RTCRtpTransceiver::create(RTCRtpSender::create(*this, "video", { }, WTFMove(senderBackend)), receiver.copyRef(), nullptr);

Nit: "video"_s

> Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:295
> +    auto transceiver = RTCRtpTransceiver::create(RTCRtpSender::create(*this, "audio", { }, WTFMove(senderBackend)), receiver.copyRef(), nullptr);

Nit: "audio"_s
Comment 3 youenn fablet 2018-09-18 14:45:40 PDT 
Created attachment 350061 [details]
Patch for landing
Comment 4 youenn fablet 2018-09-18 15:05:01 PDT 
Created attachment 350064 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2018-09-19 08:54:16 PDT 
Comment on attachment 350064 [details]
Patch for landing

Clearing flags on attachment: 350064

Committed r236207: <https://trac.webkit.org/changeset/236207>
Comment 6 WebKit Commit Bot 2018-09-19 08:54:17 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-09-19 08:55:22 PDT 
<rdar://problem/44604401>
Comment 8 youenn fablet 2018-09-20 18:34:45 PDT 
*** Bug 186248 has been marked as a duplicate of this bug. ***