Bug 189678

Summary:

[macOS WK1] Layout Test webanimations/accelerated-transition-interrupted-on-composited-element.html is a flaky image failure

Product:

WebKit

Reporter:

Ryan Haddad <ryanhaddad>

Component:

Animations

Assignee:

Antoine Quint <graouts>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, commit-queue, dino, graouts, jlewis3, realdawei, tsavell, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Ryan Haddad

Reported 2018-09-17 13:39:34 PDT

The following layout test is flaky on macOS WK1 webanimations/accelerated-transition-interrupted-on-composited-element.html Probable cause: The first failure was seen shortly after it was added in https://trac.webkit.org/changeset/235843/webkit, so it may be flaky from the start. Flakiness Dashboard: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=webanimations%2Faccelerated-transition-interrupted-on-composited-element.html Link to failure with image diff showing a black square appearing closer to the left than expected: https://build.webkit.org/results/Apple%20Sierra%20Debug%20WK1%20(Tests)/r235845%20(9470)/results.html

Attachments
Patch (2.54 KB, patch) 2019-04-04 08:55 PDT, Antoine Quint	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2018-09-19 16:31:13 PDT

Antoine Quint

Comment 2 2019-04-04 07:30:55 PDT

I can remove the flakiness with using a double rAF to conclude it. Additionally, we can improve the test by using a "transitioncancel" event.

Antoine Quint

Comment 3 2019-04-04 08:55:41 PDT

WebKit Commit Bot

Comment 4 2019-04-04 10:39:38 PDT

WebKit Commit Bot

Comment 5 2019-04-04 10:39:40 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.