Bug 189678 - [macOS WK1] Layout Test webanimations/accelerated-transition-interrupted-on-composited-element.html is a flaky image failure
Summary: [macOS WK1] Layout Test webanimations/accelerated-transition-interrupted-on-c...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-09-17 13:39 PDT by Ryan Haddad
Modified: 2019-04-04 10:39 PDT (History)
8 users (show)

See Also:


Attachments
Patch (2.54 KB, patch)
2019-04-04 08:55 PDT, Antoine Quint
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2018-09-17 13:39:34 PDT
The following layout test is flaky on macOS WK1

webanimations/accelerated-transition-interrupted-on-composited-element.html

Probable cause:

The first failure was seen shortly after it was added in https://trac.webkit.org/changeset/235843/webkit, so it may be flaky from the start.

Flakiness Dashboard:

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=webanimations%2Faccelerated-transition-interrupted-on-composited-element.html

Link to failure with image diff showing a black square appearing closer to the left than expected:
https://build.webkit.org/results/Apple%20Sierra%20Debug%20WK1%20(Tests)/r235845%20(9470)/results.html
Comment 1 Radar WebKit Bug Importer 2018-09-19 16:31:13 PDT
<rdar://problem/44621674>
Comment 2 Antoine Quint 2019-04-04 07:30:55 PDT
I can remove the flakiness with using a double rAF to conclude it. Additionally, we can improve the test by using a "transitioncancel" event.
Comment 3 Antoine Quint 2019-04-04 08:55:41 PDT
Created attachment 366717 [details]
Patch
Comment 4 WebKit Commit Bot 2019-04-04 10:39:38 PDT
Comment on attachment 366717 [details]
Patch

Clearing flags on attachment: 366717

Committed r243878: <https://trac.webkit.org/changeset/243878>
Comment 5 WebKit Commit Bot 2019-04-04 10:39:40 PDT
All reviewed patches have been landed.  Closing bug.