Bug 189656

Summary: Add more Fullscreen logging
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, jeremyj-wk, jer.noble, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch jer.noble: review+

Simon Fraser (smfr)
Reported 2018-09-16 17:43:28 PDT
Add more Fullscreen logging
Attachments
Patch (8.56 KB, patch)
2018-09-16 17:44 PDT, Simon Fraser (smfr) 		jer.noble: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2018-09-16 17:44:13 PDT
Created attachment 349874 [details] Patch
EWS Watchlist
Comment 2 2018-09-16 17:47:26 PDT
Attachment 349874 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Jer Noble
Comment 3 2018-09-17 09:58:38 PDT
Comment on attachment 349874 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=349874&action=review > Source/WebCore/platform/cocoa/VideoFullscreenModelVideoElement.mm:53 > + LOG(Fullscreen, "VideoFullscreenModelVideoElement %p ctor", this); For the model logging, you may want to consider using the runtime logging macros. (We can't currently do runtime logging for the Manager classes; they require a single Document to configure the logging.)
Simon Fraser (smfr)
Comment 4 2018-09-17 15:15:09 PDT
https://trac.webkit.org/r236088
Radar WebKit Bug Importer
Comment 5 2018-09-17 15:16:19 PDT
<rdar://problem/44536420>
Note You need to log in before you can comment on or make changes to this bug.