Bug 189615

Summary:

[WHLSL] Implement trap statements in Metal code generation

Product:

WebKit

Reporter:

Thomas Denney <tdenney>

Component:

WebGPU

Assignee:

Thomas Denney <tdenney>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, dino, ews-watchlist, mmaxfield, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
WIP	none
WIP	none
WIP	none
WIP	none
WIP	none
Patch	mmaxfield: review+
Patch	none
Patch	none

Thomas Denney

Reported 2018-09-14 00:50:54 PDT

Trap statements will be implemented by either a special boolean parameter tagged onto every function or replacing the return type of every function with a struct that contains a boolean field. The value will then be checked by the caller, and return early if necessary.

Attachments
WIP (437.32 KB, patch) 2018-09-14 16:09 PDT, Thomas Denney	no flags	Details Formatted Diff Diff
WIP (443.44 KB, patch) 2018-09-17 13:43 PDT, Thomas Denney	no flags	Details Formatted Diff Diff
WIP (423.66 KB, patch) 2018-09-20 10:33 PDT, Thomas Denney	no flags	Details Formatted Diff Diff
WIP (422.03 KB, patch) 2018-09-20 10:58 PDT, Thomas Denney	no flags	Details Formatted Diff Diff
WIP (421.31 KB, patch) 2018-09-20 11:22 PDT, Thomas Denney	no flags	Details Formatted Diff Diff
Patch (13.76 KB, patch) 2018-09-21 15:10 PDT, Thomas Denney	mmaxfield: review+	Details Formatted Diff Diff
Patch (29.59 KB, patch) 2018-09-24 20:30 PDT, Thomas Denney	no flags	Details Formatted Diff Diff
Patch (29.38 KB, patch) 2018-09-24 20:31 PDT, Thomas Denney	no flags	Details Formatted Diff Diff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.

Thomas Denney

Comment 1 2018-09-14 16:09:11 PDT

Created attachment 349823 [details] WIP

EWS Watchlist

Comment 2 2018-09-14 16:12:16 PDT

Attachment 349823 [details] did not pass style-queue: ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.m:36: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.m:81: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL ToyTests/WHLSL_ToyTests.m:11: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OffscreenRenderer.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OffscreenRenderer.m:65: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OffscreenRenderer.m:71: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestCallArgument.h:22: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestDescription.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestDescription.m:83: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:72: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:160: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:161: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:163: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:166: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:167: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:183: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:184: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:186: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:187: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:189: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:190: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:204: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:205: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.h:11: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.h:12: Alphabetical sorting problem. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.h:10: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL Tests.xcodeproj/project.pbxproj:807: developmentRegion is not English. [xcodeproj/settings] [5] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OffscreenRenderer.h:21: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestCallArgument.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CompileResult.h:15: Missing space after , [whitespace/comma] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CustomMetalView.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.m:28: One line control clauses should not use braces. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.m:144: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CompileResult.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/AppDelegate.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/Renderer.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.h:10: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.h:27: Missing space after , [whitespace/comma] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OnscreenRenderer.h:11: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:92: Missing space after , [whitespace/comma] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:99: One line control clauses should not use braces. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:109: Missing space inside { }. [whitespace/braces] [5] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:111: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:126: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:139: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:143: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:147: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:151: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:155: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:160: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:164: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:168: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:172: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:172: Missing space after , [whitespace/comma] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:180: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:184: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:188: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:192: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:196: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:200: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:205: Missing space inside { }. [whitespace/braces] [5] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:206: Missing space inside { }. [whitespace/braces] [5] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:207: Missing space inside { }. [whitespace/braces] [5] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:208: Missing space inside { }. [whitespace/braces] [5] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OnscreenRenderer.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 69 in 65 files If any of these errors are false positives, please file a bug against check-webkit-style.

Thomas Denney

Comment 3 2018-09-17 13:43:43 PDT

Created attachment 349935 [details] WIP

EWS Watchlist

Comment 4 2018-09-17 13:49:38 PDT

Attachment 349935 [details] did not pass style-queue: ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.m:36: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.m:81: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL ToyTests/WHLSL_ToyTests.m:11: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OffscreenRenderer.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OffscreenRenderer.m:65: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OffscreenRenderer.m:71: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestCallArgument.h:22: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestDescription.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestDescription.m:83: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:72: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:160: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:161: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:163: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:166: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:167: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:183: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:184: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:186: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:187: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:189: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:190: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:204: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:205: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.h:11: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.h:12: Alphabetical sorting problem. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.h:10: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL Tests.xcodeproj/project.pbxproj:807: developmentRegion is not English. [xcodeproj/settings] [5] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OffscreenRenderer.h:21: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestCallArgument.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CompileResult.h:15: Missing space after , [whitespace/comma] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CustomMetalView.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.m:28: One line control clauses should not use braces. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.m:144: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CompileResult.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/AppDelegate.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/Renderer.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.h:10: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.h:27: Missing space after , [whitespace/comma] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OnscreenRenderer.h:11: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:92: Missing space after , [whitespace/comma] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:99: One line control clauses should not use braces. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:109: Missing space inside { }. [whitespace/braces] [5] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:111: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:126: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:139: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:143: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:147: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:151: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:155: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:160: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:164: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:168: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:172: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:172: Missing space after , [whitespace/comma] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:180: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:184: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:188: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:192: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:196: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:200: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:205: Missing space inside { }. [whitespace/braces] [5] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:206: Missing space inside { }. [whitespace/braces] [5] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:207: Missing space inside { }. [whitespace/braces] [5] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:208: Missing space inside { }. [whitespace/braces] [5] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OnscreenRenderer.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 69 in 68 files If any of these errors are false positives, please file a bug against check-webkit-style.

Thomas Denney

Comment 5 2018-09-20 10:33:14 PDT

Created attachment 350228 [details] WIP

EWS Watchlist

Comment 6 2018-09-20 10:37:18 PDT

Attachment 350228 [details] did not pass style-queue: ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.m:36: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.m:81: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL ToyTests/WHLSL_ToyTests.m:11: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OffscreenRenderer.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OffscreenRenderer.m:65: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OffscreenRenderer.m:71: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestCallArgument.h:22: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestDescription.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestDescription.m:83: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OffscreenRenderer.h:21: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:72: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:160: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:161: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:163: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:166: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:167: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:183: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:184: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:186: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:187: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:189: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:190: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:204: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:205: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.h:11: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.h:12: Alphabetical sorting problem. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.h:10: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL Tests.xcodeproj/project.pbxproj:807: developmentRegion is not English. [xcodeproj/settings] [5] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestCallArgument.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CompileResult.h:15: Missing space after , [whitespace/comma] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CustomMetalView.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.m:28: One line control clauses should not use braces. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.m:145: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CompileResult.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/AppDelegate.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/Renderer.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.h:10: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.h:27: Missing space after , [whitespace/comma] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OnscreenRenderer.h:11: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:92: Missing space after , [whitespace/comma] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:99: One line control clauses should not use braces. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:109: Missing space inside { }. [whitespace/braces] [5] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:111: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:126: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:139: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:143: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:147: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:151: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:155: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:160: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:164: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:168: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:172: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:172: Missing space after , [whitespace/comma] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:180: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:184: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:188: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:192: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:196: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:200: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:205: Missing space inside { }. [whitespace/braces] [5] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:206: Missing space inside { }. [whitespace/braces] [5] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:207: Missing space inside { }. [whitespace/braces] [5] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:208: Missing space inside { }. [whitespace/braces] [5] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OnscreenRenderer.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 69 in 74 files If any of these errors are false positives, please file a bug against check-webkit-style.

Thomas Denney

Comment 7 2018-09-20 10:58:02 PDT

Created attachment 350233 [details] WIP

EWS Watchlist

Comment 8 2018-09-20 11:02:32 PDT

Attachment 350233 [details] did not pass style-queue: ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.m:36: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.m:81: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL ToyTests/WHLSL_ToyTests.m:11: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OffscreenRenderer.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OffscreenRenderer.m:65: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OffscreenRenderer.m:71: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestCallArgument.h:22: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestDescription.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestDescription.m:83: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OffscreenRenderer.h:21: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:72: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:160: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:161: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:163: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:166: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:167: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:183: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:184: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:186: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:187: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:189: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:190: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:204: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:205: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.h:11: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.h:12: Alphabetical sorting problem. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.h:10: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL Tests.xcodeproj/project.pbxproj:807: developmentRegion is not English. [xcodeproj/settings] [5] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestCallArgument.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CompileResult.h:15: Missing space after , [whitespace/comma] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CustomMetalView.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.m:28: One line control clauses should not use braces. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.m:145: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CompileResult.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/AppDelegate.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/Renderer.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.h:10: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.h:27: Missing space after , [whitespace/comma] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OnscreenRenderer.h:11: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:92: Missing space after , [whitespace/comma] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:99: One line control clauses should not use braces. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:109: Missing space inside { }. [whitespace/braces] [5] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:111: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:126: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:139: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:143: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:147: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:151: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:155: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:160: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:164: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:168: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:172: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:172: Missing space after , [whitespace/comma] [3] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:180: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:184: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:188: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:192: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:196: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:200: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:205: Missing space inside { }. [whitespace/braces] [5] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:206: Missing space inside { }. [whitespace/braces] [5] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:207: Missing space inside { }. [whitespace/braces] [5] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:208: Missing space inside { }. [whitespace/braces] [5] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OnscreenRenderer.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 69 in 74 files If any of these errors are false positives, please file a bug against check-webkit-style.

Thomas Denney

Comment 9 2018-09-20 11:22:01 PDT

Created attachment 350237 [details] WIP

EWS Watchlist

Comment 10 2018-09-20 11:26:08 PDT

Attachment 350237 [details] did not pass style-queue: ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL ToyTests/WHLSL_ToyTests.m:11: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OffscreenRenderer.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestDescription.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.h:12: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.h:11: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL Tests.xcodeproj/project.pbxproj:807: developmentRegion is not English. [xcodeproj/settings] [5] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestCallArgument.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CustomMetalView.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CompileResult.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/AppDelegate.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/Renderer.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.h:11: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OnscreenRenderer.h:11: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m:135: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Tools/WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OnscreenRenderer.m:9: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 19 in 74 files If any of these errors are false positives, please file a bug against check-webkit-style.

Thomas Denney

Comment 11 2018-09-21 15:10:55 PDT

Created attachment 350438 [details] Patch

Myles C. Maxfield

Comment 12 2018-09-24 16:31:58 PDT

Comment on attachment 350438 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=350438&action=review We can use another bug about making the metal codegen do packing/unpacking at the beginning/end of every entry point. > Tools/WebGPUShadingLanguageRI/Metal/MSLInsertTrapParameter.js:54 > + const functionVisitedOrder = []; > + const entryPointFunctions = new Set(); > + class FindEntryPoints extends Visitor { > + visitFuncDef(node) > + { > + if (node.isEntryPoint && !entryPointFunctions.has(node)) { > + entryPointFunctions.add(node); > + functionVisitedOrder.push(node); > + } > + } > + } > + program.visit(new FindEntryPoints()); > + > + const functionsCalledByEntryPoints = new Set(); > + class FindFunctionsCalledByEntryPoints extends Visitor { > + visitCallExpression(node) > + { > + super.visitCallExpression(node); > + if (node.func instanceof FuncDef && !functionsCalledByEntryPoints.has(node.func)) { > + functionsCalledByEntryPoints.add(node.func); > + functionVisitedOrder.push(node.func); > + node.func.visit(this); > + } > + } > + } > + for (let entryPoint of entryPointFunctions) > + entryPoint.visit(new FindFunctionsCalledByEntryPoints()); We've had to duplicate this code a bunch of times. We should save the results, perhaps on the program object itself. > Tools/WebGPUShadingLanguageRI/Metal/MSLStatementEmitter.js:48 > + _emitTrap(setTrapValue) I would split this function into two separate pieces and update the callers to call the relevant piece > Tools/WebGPUShadingLanguageRI/Metal/MSLStatementEmitter.js:54 > + if (this._func.returnType.name !== "void") { Should compare against program.intrinsics.void > Tools/WebGPUShadingLanguageRI/Metal/MSLStatementEmitter.js:58 > + this._add(`return ${id};`); Every return point needs to do unpacking/packing to whatever form Metal expects. This appears to do no packing. > Tools/WebGPUShadingLanguageRI/Metal/MSLStatementEmitter.js:60 > + this._add("return;"); Easier to understand if the comparison was an equality comparison, and you switch the order of the two blocks > Tools/WebGPUShadingLanguageRI/Metal/MSLStatementEmitter.js:268 > + this._add(`}`); > + return `(*(${ptr}))`; What? The line above is "return". When will this ever be executed? > Tools/WebGPUShadingLanguageRI/Test.js:2503 > + const numVars = 50; // Originally this was 1024 but that was too slow No reason for the comment, 50 is fine. > Tools/WebGPUShadingLanguageRI/Test.js:8323 > +tests.INTERPRETER_DISABLED_trapTransitively = () => { We should modify the interpreter to have the same behavior as the real code gen. Should be easy - just make the root entry point catch the TrapException

Thomas Denney

Comment 13 2018-09-24 16:48:37 PDT

Comment on attachment 350438 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=350438&action=review >> Tools/WebGPUShadingLanguageRI/Metal/MSLStatementEmitter.js:58 >> + this._add(`return ${id};`); > > Every return point needs to do unpacking/packing to whatever form Metal expects. This appears to do no packing. https://bugs.webkit.org/show_bug.cgi?id=189936

Thomas Denney

Comment 14 2018-09-24 20:30:23 PDT

Created attachment 350732 [details] Patch

Thomas Denney

Comment 15 2018-09-24 20:31:44 PDT

Created attachment 350733 [details] Patch

Thomas Denney

Comment 16 2018-09-24 20:32:55 PDT

(In reply to Myles C. Maxfield from comment #12) > Comment on attachment 350438 [details] > Patch > > We've had to duplicate this code a bunch of times. We should save the > results, perhaps on the program object itself. Agreed, but I’ll do it in a separate patch seen as it involves refactoring a few places https://bugs.webkit.org/show_bug.cgi?id=189943.

WebKit Commit Bot

Comment 17 2018-09-24 21:15:14 PDT

Comment on attachment 350733 [details] Patch Clearing flags on attachment: 350733 Committed r236452: <https://trac.webkit.org/changeset/236452>

Radar WebKit Bug Importer

Comment 18 2018-09-25 12:48:30 PDT

<rdar://problem/44770603>

Note You need to log in before you can comment on or make changes to this bug.