| Summary: | Remove unused code in WebKitLegacy | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||||
| Component: | New Bugs | Assignee: | Tim Horton <thorton> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | andersca, ap, commit-queue, ggaren, mitz, simon.fraser, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Tim Horton
2018-09-14 00:33:46 PDT
Created attachment 349744 [details]
Patch
Ccing some folks to tell me why we can't. It's also somewhat possible we have to keep stub headers around, will try to see if that's the case. Comment on attachment 349744 [details]
Patch
Actually, I know why. Will return to this in the not too distant future.
😮 A cursory glance at the internet suggests that there are many people who do import these two public headers directly, so perhaps we do need to leave them behind (and empty)? (In reply to Tim Horton from comment #6) > A cursory glance at the internet suggests that there are many people who do > import these two public headers directly, so perhaps we do need to leave > them behind (and empty)? I think (and Dan agrees) that you can go ahead and remove them. It's not unusual for people to have to fix their project builds when moving to a newer SDK. Perfect. Created attachment 363366 [details]
Patch
Comment on attachment 363366 [details] Patch Clearing flags on attachment: 363366 Committed r242287: <https://trac.webkit.org/changeset/242287> All reviewed patches have been landed. Closing bug. |