|Summary:||Remove unused code in WebKitLegacy|
|Product:||WebKit||Reporter:||Tim Horton <thorton>|
|Component:||New Bugs||Assignee:||Tim Horton <thorton>|
|Severity:||Normal||CC:||andersca, ap, commit-queue, ggaren, mitz, simon.fraser, webkit-bug-importer|
|Version:||WebKit Nightly Build|
Description Tim Horton 2018-09-14 00:33:46 PDT
Remove unused code in WebKitLegacy
Comment 2 Tim Horton 2018-09-14 00:35:14 PDT
Ccing some folks to tell me why we can't.
Comment 3 Tim Horton 2018-09-14 00:35:45 PDT
It's also somewhat possible we have to keep stub headers around, will try to see if that's the case.
Comment 4 Tim Horton 2018-09-14 02:10:12 PDT
Comment on attachment 349744 [details] Patch Actually, I know why. Will return to this in the not too distant future.
Comment 5 Anders Carlsson 2019-02-28 18:05:26 PST
Comment 6 Tim Horton 2019-03-01 00:14:04 PST
A cursory glance at the internet suggests that there are many people who do import these two public headers directly, so perhaps we do need to leave them behind (and empty)?
Comment 7 Anders Carlsson 2019-03-01 13:14:01 PST
(In reply to Tim Horton from comment #6) > A cursory glance at the internet suggests that there are many people who do > import these two public headers directly, so perhaps we do need to leave > them behind (and empty)? I think (and Dan agrees) that you can go ahead and remove them. It's not unusual for people to have to fix their project builds when moving to a newer SDK.
Comment 8 Tim Horton 2019-03-01 13:27:22 PST
Comment 10 WebKit Commit Bot 2019-03-01 13:58:52 PST
Comment on attachment 363366 [details] Patch Clearing flags on attachment: 363366 Committed r242287: <https://trac.webkit.org/changeset/242287>
Comment 11 WebKit Commit Bot 2019-03-01 13:58:53 PST
All reviewed patches have been landed. Closing bug.