Bug 189614

Summary: Remove unused code in WebKitLegacy
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, ap, commit-queue, ggaren, mitz, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Tim Horton
Reported 2018-09-14 00:33:46 PDT
Remove unused code in WebKitLegacy
Attachments
Patch (162.86 KB, patch)
2018-09-14 00:34 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (160.38 KB, patch)
2019-03-01 13:29 PST, Tim Horton 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2018-09-14 00:34:50 PDT
Created attachment 349744 [details] Patch
Tim Horton
Comment 2 2018-09-14 00:35:14 PDT
Ccing some folks to tell me why we can't.
Tim Horton
Comment 3 2018-09-14 00:35:45 PDT
It's also somewhat possible we have to keep stub headers around, will try to see if that's the case.
Tim Horton
Comment 4 2018-09-14 02:10:12 PDT
Comment on attachment 349744 [details] Patch Actually, I know why. Will return to this in the not too distant future.
Anders Carlsson
Comment 5 2019-02-28 18:05:26 PST
😮
Tim Horton
Comment 6 2019-03-01 00:14:04 PST
A cursory glance at the internet suggests that there are many people who do import these two public headers directly, so perhaps we do need to leave them behind (and empty)?
Anders Carlsson
Comment 7 2019-03-01 13:14:01 PST
(In reply to Tim Horton from comment #6) > A cursory glance at the internet suggests that there are many people who do > import these two public headers directly, so perhaps we do need to leave > them behind (and empty)? I think (and Dan agrees) that you can go ahead and remove them. It's not unusual for people to have to fix their project builds when moving to a newer SDK.
Tim Horton
Comment 8 2019-03-01 13:27:22 PST
Perfect.
Tim Horton
Comment 9 2019-03-01 13:29:35 PST
Created attachment 363366 [details] Patch
WebKit Commit Bot
Comment 10 2019-03-01 13:58:52 PST
Comment on attachment 363366 [details] Patch Clearing flags on attachment: 363366 Committed r242287: <https://trac.webkit.org/changeset/242287>
WebKit Commit Bot
Comment 11 2019-03-01 13:58:53 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 12 2019-03-01 13:59:53 PST
<rdar://problem/48521996>
Note You need to log in before you can comment on or make changes to this bug.