Summary: | [Win][Clang][WebKitLegacy] error: cannot pass object of non-trivial type through variadic function | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Fujii Hironori <Hironori.Fujii> | ||||
Component: | WebKit Misc. | Assignee: | Fujii Hironori <Hironori.Fujii> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | achristensen, bfulgham, pvollan, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 171618 | ||||||
Attachments: |
|
Description
Fujii Hironori
2018-09-13 20:19:44 PDT
MSVC reports compilation warnings. > 1>------ Build started: Project: WebKitLegacy (WebKitLegacy\WebKitLegacy), Configuration: Debug x64 ------ > 1>DefaultPolicyDelegate.cpp > 1>c:\webkit\ga\source\webkitlegacy\win\defaultpolicydelegate.cpp(182): warning C4840: non-portable use of class 'WebCore::BString' as an argument to a variadic function > 1>c:\webkit\ga\source\webkitlegacy\win\defaultpolicydelegate.cpp(182): note: 'WebCore::BString::BString' is non-trivial > 1>c:\webkit\ga\webkitbuild\debug\derivedsources\forwardingheaders\webcore\bstring.h(61): note: see declaration of 'WebCore::BString::BString' > 1>c:\webkit\ga\source\webkitlegacy\win\defaultpolicydelegate.cpp(182): note: the constructor and destructor will not be called; a bitwise copy of the class will be passed as the argument > 1>c:\webkit\ga\webkitbuild\debug\derivedsources\forwardingheaders\webcore\bstring.h(45): note: see declaration of 'WebCore::BString' > 1>Done building project "WebKitLegacy.vcxproj". > ========== Build: 1 succeeded, 0 failed, 0 up-to-date, 0 skipped ========== > 1>------ Build started: Project: WebKitLegacy (WebKitLegacy\WebKitLegacy), Configuration: Debug x64 ------ > 1>WebLocalizableStrings.cpp > 1>c:\webkit\ga\source\webkitlegacy\win\weblocalizablestrings.cpp(164): warning C4840: non-portable use of class 'WTF::String' as an argument to a variadic function > 1>c:\webkit\ga\source\webkitlegacy\win\weblocalizablestrings.cpp(164): note: 'WTF::String::String' is non-trivial > 1>c:\webkit\ga\webkitbuild\debug\derivedsources\forwardingheaders\wtf\text\wtfstring.h(130): note: see declaration of 'WTF::String::String' > 1>c:\webkit\ga\source\webkitlegacy\win\weblocalizablestrings.cpp(164): note: the constructor and destructor will not be called; a bitwise copy of the class will be passed as the argument > 1>c:\webkit\ga\webkitbuild\debug\derivedsources\forwardingheaders\wtf\text\wtfstring.h(78): note: see declaration of 'WTF::String' > 1>Done building project "WebKitLegacy.vcxproj". > ========== Build: 1 succeeded, 0 failed, 0 up-to-date, 0 skipped ========== Created attachment 349729 [details]
Patch
Comment on attachment 349729 [details] Patch Clearing flags on attachment: 349729 Committed r236099: <https://trac.webkit.org/changeset/236099> All reviewed patches have been landed. Closing bug. |