Bug 189577

Summary: Remove a MSVC workaround in InspectorStyle::styleWithProperties
Product: WebKit Reporter: Fujii Hironori <fujii.hironori>
Component: Web InspectorAssignee: Fujii Hironori <fujii.hironori>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, burg, commit-queue, ews-watchlist, inspector-bugzilla-changes, joepeck, pvollan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews122 for ios-simulator-wk2 none

Fujii Hironori
Reported 2018-09-13 00:51:51 PDT
Remove a MSVC workaround in InspectorStyle::styleWithProperties It is introduced in Bug 131596 Comment 11. > // Visual Studio disagrees with other compilers as to whether 'class' is needed here. > #if COMPILER(MSVC) > enum class Protocol::CSS::CSSPropertyStatus status; > #else > enum Inspector::Protocol::CSS::CSSPropertyStatus status; > #endif
Attachments
Patch (2.05 KB, patch)
2018-09-13 00:56 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews122 for ios-simulator-wk2 (2.58 MB, application/zip)
2018-09-13 04:18 PDT, EWS Watchlist 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2018-09-13 00:56:58 PDT
Created attachment 349641 [details] Patch
EWS Watchlist
Comment 2 2018-09-13 04:18:37 PDT
Comment on attachment 349641 [details] Patch Attachment 349641 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/9201461 New failing tests: fast/animation/css-animation-resuming-when-visible-with-style-change2.html
EWS Watchlist
Comment 3 2018-09-13 04:18:39 PDT
Created attachment 349653 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4
WebKit Commit Bot
Comment 4 2018-09-13 10:16:12 PDT
Comment on attachment 349641 [details] Patch Clearing flags on attachment: 349641 Committed r235977: <https://trac.webkit.org/changeset/235977>
WebKit Commit Bot
Comment 5 2018-09-13 10:16:14 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2018-09-13 10:17:29 PDT
<rdar://problem/44422014>
Joseph Pecoraro
Comment 7 2018-09-13 10:30:16 PDT
Nice!
Note You need to log in before you can comment on or make changes to this bug.