Bug 189553 – SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds

• Component: New Bugs
• Status: RESOLVED FIXED

[Jer Noble]

SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds

[Jer Noble]

Created attachment 349561 [details]
Patch

[EWS Watchlist]

Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE

[Tim Horton]

Comment on attachment 349561 [details]
Patch

Can you make these all identical and add them to sync-feature-defines??? It's SO helpful.

[Tim Horton]

(I realize they're not feature defines, maybe we can rename the script... sync-shared-xcconfigs?)

[Jer Noble]

(In reply to Tim Horton from comment #3)
> Comment on attachment 349561 [details]
> Patch
> 
> Can you make these all identical and add them to sync-feature-defines???
> It's SO helpful.
>
> (I realize they're not feature defines, maybe we can rename the script...
> sync-shared-xcconfigs?)

Well, all the SDKVariant.xcconfig files are identical. I'll look into it though!

[Jer Noble]

Created attachment 349588 [details]
Patch

[EWS Watchlist]

Comment on attachment 349588 [details]
Patch

Attachment 349588 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/9196542

Number of test failures exceeded the failure limit.

[EWS Watchlist]

Created attachment 349598 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.4

[EWS Watchlist]

Comment on attachment 349588 [details]
Patch

Attachment 349588 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/9197323

New failing tests:
accessibility/smart-invert-reference.html

[EWS Watchlist]

Created attachment 349606 [details]
Archive of layout-test-results from ews104 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[Jer Noble]

Created attachment 353528 [details]
Patch

[Tim Horton]

Comment on attachment 353528 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353528&action=review

> Source/ThirdParty/libwebrtc/Configurations/Base.xcconfig:2
> +#include "SDKVariant.xcconfign"

I think you have an extra "n"

[Tim Horton]

(In reply to Jer Noble from comment #5)
> (In reply to Tim Horton from comment #3)
> > Comment on attachment 349561 [details]
> > Patch
> > 
> > Can you make these all identical and add them to sync-feature-defines???
> > It's SO helpful.
> >
> > (I realize they're not feature defines, maybe we can rename the script...
> > sync-shared-xcconfigs?)
> 
> Well, all the SDKVariant.xcconfig files are identical.

Right, that's literally the point. To make sure they stay that way.

> I'll look into it though!

[Jer Noble]

(In reply to Tim Horton from comment #12)
> Comment on attachment 353528 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=353528&action=review
> 
> > Source/ThirdParty/libwebrtc/Configurations/Base.xcconfig:2
> > +#include "SDKVariant.xcconfign"
> 
> I think you have an extra "n"

Ack!

[Jer Noble]

Created attachment 353536 [details]
Patch

[Tim Horton]

Comment on attachment 353536 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353536&action=review

> PerformanceTests/MediaTime/Configurations/SDKVariant.xcconfig:43
> +EFFECTIVE_PLATFORM_NAME = $(EFFECTIVE_PLATFORM_NAME_ALTERNATE_$(WK_USE_ALTERNATE_PLATFORM_NAME)

Isn't this missing a close paren and semicolon

[Jer Noble]

(In reply to Tim Horton from comment #16)
> Comment on attachment 353536 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=353536&action=review
> 
> > PerformanceTests/MediaTime/Configurations/SDKVariant.xcconfig:43
> > +EFFECTIVE_PLATFORM_NAME = $(EFFECTIVE_PLATFORM_NAME_ALTERNATE_$(WK_USE_ALTERNATE_PLATFORM_NAME)
> 
> Isn't this missing a close paren and semicolon

Apparently not, since that line is what controls the build directory and the build directory is set as you'd expect when you build with SDK_VARIANT=. But yes, I'll fix it.

[Jer Noble]

Created attachment 353552 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/45727881>

[Jer Noble]

Created attachment 358965 [details]
Patch

[Tim Horton]

Comment on attachment 358965 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=358965&action=review

I don't love the new xcconfigs.

> Tools/ChangeLog:22
> +        SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds

Double changelog

> Tools/ContentExtensionTester/Configurations/SDKVariant.xcconfig:1
> +// Copyright (C) 2018 Apple Inc. All rights reserved.

The year has changed

[Jer Noble]

(In reply to Tim Horton from comment #21)
> Comment on attachment 358965 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=358965&action=review
> 
> I don't love the new xcconfigs.

I'm hopeful we can unify all the "same for every subproject xcconfig" files into a smaller set of xcconfig files.

> > Tools/ChangeLog:22
> > +        SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
> 
> Double changelog

Will fix.

> > Tools/ContentExtensionTester/Configurations/SDKVariant.xcconfig:1
> > +// Copyright (C) 2018 Apple Inc. All rights reserved.
> 
> The year has changed

It's 2019 and I'm still writing 2018 on all my copyright statements.

[Jer Noble]

Created attachment 359375 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 359375 [details]
Patch for landing

Clearing flags on attachment: 359375

Committed r240124: <https://trac.webkit.org/changeset/240124>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Truitt Savell]

Reverted r240124 for reason:

This commit broke an internal build.

Committed r240136: <https://trac.webkit.org/changeset/240136>

[Jer Noble]

Created attachment 359526 [details]
Patch for landing

[Jer Noble]

Created attachment 359527 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 359527 [details]
Patch for landing

Clearing flags on attachment: 359527

Committed r240176: <https://trac.webkit.org/changeset/240176>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.