| Summary: | Add enterkeyhint support | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | David Tapuska <dave+webkit> | ||||||
| Component: | DOM | Assignee: | Wenson Hsieh <wenson_hsieh> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | annulen, bdakin, cdumez, commit-queue, dbates, eoconnor, ews-watchlist, gyuyoung.kim, megan_gardner, ryuan.choi, sergio, thorton, webkit-bug-importer, wenson_hsieh | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
David Tapuska
2018-09-12 07:22:27 PDT
s/enterkeylabel/enterkeyhint Example: http://output.jsbin.com/mukira Created attachment 382150 [details]
Patch
Created attachment 382151 [details]
Fix GTK/WPE builds
Comment on attachment 382151 [details] Fix GTK/WPE builds Rejecting attachment 382151 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 382151, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=382151&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=189546&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Processing patch 382151 from bug 189546. Fetching: https://bugs.webkit.org/attachment.cgi?id=382151 Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Tim Horton']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 10 diffs from patch file(s). patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebKit/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/Headers.cmake patching file Source/WebKit/Shared/FocusedElementInformation.cpp patching file Source/WebKit/Shared/FocusedElementInformation.h patching file Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm patching file Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm patching file Tools/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj Hunk #1 succeeded at 1032 (offset 1 line). Hunk #2 FAILED at 1460. Hunk #3 succeeded at 2557 (offset 1 line). Hunk #4 succeeded at 3137 (offset 1 line). Hunk #5 succeeded at 4568 (offset 2 lines). 1 out of 5 hunks FAILED -- saving rejects to file Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj.rej patching file Tools/TestWebKitAPI/Tests/ios/EnterKeyHintTests.mm Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Tim Horton']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: https://webkit-queues.webkit.org/results/13188930 |