Bug 189530

Summary: [Curl] Bug fix on some inaccurate values in NetworkLoadMetrics.
Product: WebKit Reporter: Basuke Suzuki <basuke>
Component: PlatformAssignee: Basuke Suzuki <basuke>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, basuke, commit-queue, darin, ews-watchlist, fujii.hironori, galpeter, pvollan, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
PATCH
none
PATCH none

Basuke Suzuki
Reported 2018-09-11 16:47:06 PDT
The timing information curl returns is calculated based on the curl_ease_perform(), which is invoked in background thread. The real metrics should be started at the timing of request handler (CurlRequest) started timing.
Attachments
PATCH (14.28 KB, patch)
2018-09-14 15:17 PDT, Basuke Suzuki 		no flags
DetailsFormatted DiffDiff
PATCH (14.34 KB, patch)
2018-09-14 15:31 PDT, Basuke Suzuki 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Basuke Suzuki
Comment 1 2018-09-14 15:17:47 PDT
Created attachment 349815 [details] PATCH responseEnd was implemented correctly. Also initial delay caused by the gap from main thread to curl thread was adjusted.
Basuke Suzuki
Comment 2 2018-09-14 15:31:13 PDT
Created attachment 349819 [details] PATCH
WebKit Commit Bot
Comment 3 2018-09-14 17:46:54 PDT
Comment on attachment 349819 [details] PATCH Clearing flags on attachment: 349819 Committed r236029: <https://trac.webkit.org/changeset/236029>
WebKit Commit Bot
Comment 4 2018-09-14 17:46:56 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2018-09-14 17:47:38 PDT
<rdar://problem/44475694>
Note You need to log in before you can comment on or make changes to this bug.