Bug 189521

Summary:

Make GraphicsLayers ref-counted, so their tree can persist when disconnected from RenderLayerBackings

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

New Bugs

Assignee:

Simon Fraser (smfr) <simon.fraser>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ddkilzer, ews-watchlist, rniwa, ryanhaddad, simon.fraser, thorton, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Archive of layout-test-results from ews123 for ios-simulator-wk2	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	ews-watchlist: commit-queue-
Archive of layout-test-results from ews121 for ios-simulator-wk2	none
Archive of layout-test-results from ews107 for mac-sierra-wk2	none
Patch	none
Archive of layout-test-results from ews107 for mac-sierra-wk2	none
Archive of layout-test-results from ews123 for ios-simulator-wk2	none
Patch	thorton: review+

Simon Fraser (smfr)

Reported 2018-09-11 14:10:59 PDT

Make GraphicsLayers ref-counted, so their tree can persist when disconnected from RenderLayerBackings

Attachments
Patch (87.72 KB, patch) 2018-09-11 14:14 PDT, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Patch (96.60 KB, patch) 2018-09-11 14:44 PDT, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Patch (97.86 KB, patch) 2018-09-11 14:58 PDT, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Patch (99.14 KB, patch) 2018-09-11 15:29 PDT, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Patch (101.39 KB, patch) 2018-09-11 15:40 PDT, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Patch (102.49 KB, patch) 2018-09-11 15:51 PDT, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Patch (103.09 KB, patch) 2018-09-11 16:03 PDT, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews123 for ios-simulator-wk2 (21.06 MB, application/zip) 2018-09-11 16:21 PDT, EWS Watchlist	no flags	Details
Patch (102.68 KB, patch) 2018-09-11 16:22 PDT, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Patch (102.68 KB, patch) 2018-09-11 17:49 PDT, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Patch (102.49 KB, patch) 2018-09-11 19:10 PDT, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Patch (104.37 KB, patch) 2018-09-11 19:46 PDT, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Patch (104.87 KB, patch) 2018-09-11 19:57 PDT, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Patch (105.33 KB, patch) 2018-09-11 21:35 PDT, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Patch (104.52 KB, patch) 2018-09-11 21:58 PDT, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Patch (103.83 KB, patch) 2018-09-11 22:26 PDT, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Patch (104.17 KB, patch) 2018-09-11 23:11 PDT, Simon Fraser (smfr)	ews-watchlist: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews121 for ios-simulator-wk2 (2.33 MB, application/zip) 2018-09-12 00:55 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews107 for mac-sierra-wk2 (3.29 MB, application/zip) 2018-09-12 01:06 PDT, EWS Watchlist	no flags	Details
Patch (107.42 KB, patch) 2018-09-12 08:19 PDT, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews107 for mac-sierra-wk2 (3.17 MB, application/zip) 2018-09-12 09:35 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews123 for ios-simulator-wk2 (2.36 MB, application/zip) 2018-09-12 10:22 PDT, EWS Watchlist	no flags	Details
Patch (133.13 KB, patch) 2018-09-13 18:29 PDT, Simon Fraser (smfr)	thorton: review+	Details Formatted Diff Diff
Show Obsolete (22) View All Add attachment proposed patch, testcase, etc.

Simon Fraser (smfr)

Comment 1 2018-09-11 14:14:18 PDT

Created attachment 349449 [details] Patch

Tim Horton

Comment 2 2018-09-11 14:23:37 PDT

Comment on attachment 349449 [details] Patch Please remove the logging.

Radar WebKit Bug Importer

Comment 3 2018-09-11 14:30:53 PDT

<rdar://problem/44357032>

Simon Fraser (smfr)

Comment 4 2018-09-11 14:44:27 PDT Comment hidden (obsolete)

Created attachment 349460 [details] Patch

Simon Fraser (smfr)

Comment 5 2018-09-11 14:58:30 PDT Comment hidden (obsolete)

Created attachment 349464 [details] Patch

Simon Fraser (smfr)

Comment 6 2018-09-11 15:29:17 PDT Comment hidden (obsolete)

Created attachment 349475 [details] Patch

Simon Fraser (smfr)

Comment 7 2018-09-11 15:40:14 PDT Comment hidden (obsolete)

Created attachment 349477 [details] Patch

Simon Fraser (smfr)

Comment 8 2018-09-11 15:51:40 PDT

Created attachment 349483 [details] Patch

Simon Fraser (smfr)

Comment 9 2018-09-11 16:03:44 PDT

Created attachment 349485 [details] Patch

EWS Watchlist

Comment 10 2018-09-11 16:20:59 PDT

Comment on attachment 349449 [details] Patch Attachment 349449 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/9179534 New failing tests: compositing/scrolling/touch-scroll-to-clip.html

EWS Watchlist

Comment 11 2018-09-11 16:21:01 PDT

Created attachment 349487 [details] Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4

Simon Fraser (smfr)

Comment 12 2018-09-11 16:22:49 PDT Comment hidden (obsolete)

Created attachment 349488 [details] Patch

Simon Fraser (smfr)

Comment 13 2018-09-11 17:49:46 PDT Comment hidden (obsolete)

Created attachment 349498 [details] Patch

Simon Fraser (smfr)

Comment 14 2018-09-11 19:10:33 PDT Comment hidden (obsolete)

Created attachment 349504 [details] Patch

Simon Fraser (smfr)

Comment 15 2018-09-11 19:46:03 PDT Comment hidden (obsolete)

Created attachment 349506 [details] Patch

Simon Fraser (smfr)

Comment 16 2018-09-11 19:57:16 PDT Comment hidden (obsolete)

Created attachment 349507 [details] Patch

Simon Fraser (smfr)

Comment 17 2018-09-11 21:35:45 PDT Comment hidden (obsolete)

Created attachment 349519 [details] Patch

Simon Fraser (smfr)

Comment 18 2018-09-11 21:58:00 PDT Comment hidden (obsolete)

Created attachment 349520 [details] Patch

Simon Fraser (smfr)

Comment 19 2018-09-11 22:26:07 PDT Comment hidden (obsolete)

Created attachment 349522 [details] Patch

Simon Fraser (smfr)

Comment 20 2018-09-11 23:11:49 PDT

Created attachment 349525 [details] Patch

EWS Watchlist

Comment 21 2018-09-12 00:55:28 PDT

Comment on attachment 349525 [details] Patch Attachment 349525 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/9188407 New failing tests: compositing/scrolling/touch-scroll-to-clip.html

EWS Watchlist

Comment 22 2018-09-12 00:55:30 PDT

Created attachment 349529 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4

EWS Watchlist

Comment 23 2018-09-12 01:06:27 PDT

Comment on attachment 349525 [details] Patch Attachment 349525 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/9188673 New failing tests: pageoverlay/overlay-remove-reinsert-view.html

EWS Watchlist

Comment 24 2018-09-12 01:06:29 PDT

Created attachment 349530 [details] Archive of layout-test-results from ews107 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

Simon Fraser (smfr)

Comment 25 2018-09-12 08:19:00 PDT

Created attachment 349547 [details] Patch

EWS Watchlist

Comment 26 2018-09-12 09:35:09 PDT

Comment on attachment 349547 [details] Patch Attachment 349547 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/9192253 New failing tests: pageoverlay/overlay-remove-reinsert-view.html

EWS Watchlist

Comment 27 2018-09-12 09:35:11 PDT

Created attachment 349556 [details] Archive of layout-test-results from ews107 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 28 2018-09-12 10:22:13 PDT

Comment on attachment 349547 [details] Patch Attachment 349547 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/9192538 New failing tests: compositing/scrolling/touch-scroll-to-clip.html

EWS Watchlist

Comment 29 2018-09-12 10:22:15 PDT

Created attachment 349559 [details] Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4

Simon Fraser (smfr)

Comment 30 2018-09-12 14:27:42 PDT

https://trac.webkit.org/r235953

Ryan Haddad

Comment 31 2018-09-13 10:21:02 PDT

Reverted r235953 for reason: Caused layout test crashes under GuardMalloc. Committed r235979: <https://trac.webkit.org/changeset/235979>

David Kilzer (:ddkilzer)

Comment 32 2018-09-13 10:33:06 PDT

(In reply to Ryan Haddad from comment #31) > Reverted r235953 for reason: > > Caused layout test crashes under GuardMalloc. > > Committed r235979: <https://trac.webkit.org/changeset/235979> Strangely, rolling this patch out also fixed 8 leaks on our internal leaks bot?!

David Kilzer (:ddkilzer)

Comment 33 2018-09-13 10:35:13 PDT

(In reply to David Kilzer (:ddkilzer) from comment #32) > (In reply to Ryan Haddad from comment #31) > > Reverted r235953 for reason: > > > > Caused layout test crashes under GuardMalloc. > > > > Committed r235979: <https://trac.webkit.org/changeset/235979> > > Strangely, rolling this patch out also fixed 8 leaks on our internal leaks > bot?! Oops, I meant "static analyzer issues", not "leaks" above.

Ryan Haddad

Comment 34 2018-09-13 12:23:00 PDT

This also seems to have caused compositing/scrolling/touch-scroll-to-clip.html to fail on iOS Simulator: --- /Volumes/Data/slave/ios-simulator-11-release-tests-wk2/build/layout-test-results/compositing/scrolling/touch-scroll-to-clip-expected.txt +++ /Volumes/Data/slave/ios-simulator-11-release-tests-wk2/build/layout-test-results/compositing/scrolling/touch-scroll-to-clip-actual.txt @@ -9,7 +9,18 @@ (GraphicsLayer (position 8.00 8.00) (bounds 320.00 440.00) - (children 1 + (children 2 + (GraphicsLayer + (offsetFromRenderer width=-20 height=-20) + (position 20.00 20.00) + (bounds 280.00 400.00) + (children 1 + (GraphicsLayer + (offsetFromRenderer width=20 height=20) + (bounds 280.00 500.00) + ) + ) + ) (GraphicsLayer (offsetFromRenderer width=20 height=20) (position 20.00 20.00) https://build.webkit.org/results/Apple%20iOS%2011%20Simulator%20Release%20WK2%20(Tests)/r235978%20(7401)/results.html

Simon Fraser (smfr)

Comment 35 2018-09-13 18:29:54 PDT

Created attachment 349720 [details] Patch

Simon Fraser (smfr)

Comment 36 2018-09-14 12:52:26 PDT

https://trac.webkit.org/changeset/236016/webkit

Simon Fraser (smfr)

Comment 37 2018-09-14 13:35:33 PDT

*** Bug 189572 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.