Bug 189465

Summary: XMLHttpRequest: overrideMimeType should not update the response's "Content-Type" header
Product: WebKit Reporter: Rob Buis <rbuis>
Component: Page LoadingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, commit-queue, fred.wang, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Rob Buis
Reported 2018-09-09 11:53:49 PDT
From the spec: Acts as if the `Content-Type` header value for response is mime. (It does not actually change the header though.) https://xhr.spec.whatwg.org/#dom-xmlhttprequest-overridemimetype
Attachments
Patch (4.83 KB, patch)
2018-09-09 11:58 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (6.55 KB, patch)
2018-09-09 12:27 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (7.06 KB, patch)
2018-09-10 00:06 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (7.07 KB, patch)
2018-09-10 00:47 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Rob Buis
Comment 1 2018-09-09 11:58:21 PDT
Created attachment 349289 [details] Patch
Rob Buis
Comment 2 2018-09-09 12:27:02 PDT
Created attachment 349291 [details] Patch
Frédéric Wang (:fredw)
Comment 3 2018-09-09 23:40:28 PDT
Comment on attachment 349291 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=349291&action=review > Source/WebCore/ChangeLog:9 > + response's "Content-Type" header anymore. Are you able to provide a link to a spec change (github issue or something) showing that change? > Source/WebCore/xml/XMLHttpRequest.cpp:-969 > - m_response.setHTTPHeaderField(HTTPHeaderName::ContentType, m_mimeTypeOverride); Can you please also remove the FIXME comment from XMLHttpRequest::didReceiveData? (I guess setting the m_responseEncoding from m_mimeTypeOverride is still valid, right?).
Rob Buis
Comment 4 2018-09-10 00:06:27 PDT
Created attachment 349296 [details] Patch
Frédéric Wang (:fredw)
Comment 5 2018-09-10 00:33:33 PDT
For reference, "Acts as if the `Content-Type` header value for response is mime. (It does not actually change the header though.)" was added in https://github.com/whatwg/xhr/commit/121cee50b6f51215f046266642964b4c53a02a7c
WebKit Commit Bot
Comment 6 2018-09-10 00:35:23 PDT
Comment on attachment 349296 [details] Patch Rejecting attachment 349296 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 349296, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in LayoutTests/ChangeLog contains OOPS!. Full output: https://webkit-queues.webkit.org/results/9158067
Rob Buis
Comment 7 2018-09-10 00:47:39 PDT
Created attachment 349299 [details] Patch
WebKit Commit Bot
Comment 8 2018-09-10 01:28:09 PDT
Comment on attachment 349299 [details] Patch Clearing flags on attachment: 349299 Committed r235844: <https://trac.webkit.org/changeset/235844>
WebKit Commit Bot
Comment 9 2018-09-10 01:28:11 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 10 2018-09-10 01:29:22 PDT
<rdar://problem/44295412>
Note You need to log in before you can comment on or make changes to this bug.