Bug 189452

Summary: Clean up code related to Document node removal
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, cmarcelo, dbates, esprehn+autocc, ews-watchlist, japhet, kangil.han, n_wang, rniwa, simon.fraser, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch wenson_hsieh: review+

Simon Fraser (smfr)
Reported 2018-09-08 12:34:13 PDT
Clean up code related to Document node removal
Attachments
Patch (9.12 KB, patch)
2018-09-08 12:35 PDT, Simon Fraser (smfr) 		wenson_hsieh: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2018-09-08 12:35:56 PDT
Created attachment 349258 [details] Patch
Wenson Hsieh
Comment 2 2018-09-08 13:15:25 PDT
Comment on attachment 349258 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=349258&action=review > Source/WebCore/dom/Document.h:760 > + enum class NodeRemoval { Node, ChildrenOfNode }; Do we care about shrinking the width of enums that are only passed around as arguments, and not stored anywhere? (If so, this should be 8 bits)
Simon Fraser (smfr)
Comment 3 2018-09-08 13:20:07 PDT
https://trac.webkit.org/r235830
Radar WebKit Bug Importer
Comment 4 2018-09-08 13:21:25 PDT
<rdar://problem/44263412>
Note You need to log in before you can comment on or make changes to this bug.