Bug 189438

Summary:

[MediaCapabilities] Implement MediaEngineConfigurationFactory registration

Product:

WebKit

Reporter:

Jer Noble <jer.noble>

Component:

New Bugs

Assignee:

Jer Noble <jer.noble>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, eric.carlson, ews-watchlist, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	ews-watchlist: commit-queue-
Archive of layout-test-results from ews106 for mac-sierra-wk2	none
Archive of layout-test-results from ews112 for mac-sierra	none
Archive of layout-test-results from ews122 for ios-simulator-wk2	none
Archive of layout-test-results from ews103 for mac-sierra	none
Archive of layout-test-results from ews124 for ios-simulator-wk2	none
Patch	none
Patch	none

Jer Noble

Reported 2018-09-07 15:45:01 PDT

[MediaCapabilities] Implement MediaEngineConfigurationFactory registration

Attachments
Patch (81.87 KB, patch) 2018-09-07 16:14 PDT, Jer Noble	ews-watchlist: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews106 for mac-sierra-wk2 (3.02 MB, application/zip) 2018-09-07 17:21 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews112 for mac-sierra (3.05 MB, application/zip) 2018-09-07 17:55 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews122 for ios-simulator-wk2 (2.25 MB, application/zip) 2018-09-07 18:16 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews103 for mac-sierra (2.30 MB, application/zip) 2018-09-07 19:15 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews124 for ios-simulator-wk2 (2.27 MB, application/zip) 2018-09-07 20:17 PDT, EWS Watchlist	no flags	Details
Patch (84.84 KB, patch) 2018-09-10 09:57 PDT, Jer Noble	no flags	Details Formatted Diff Diff
Patch (84.81 KB, patch) 2018-09-10 10:07 PDT, Jer Noble	no flags	Details Formatted Diff Diff
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.

Jer Noble

Comment 1 2018-09-07 16:14:44 PDT

Created attachment 349214 [details] Patch

EWS Watchlist

Comment 2 2018-09-07 17:21:54 PDT Comment hidden (obsolete)

Comment on attachment 349214 [details] Patch Attachment 349214 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/9134647 New failing tests: media/mediacapabilities/mediacapabilities-types.html

EWS Watchlist

Comment 3 2018-09-07 17:21:55 PDT Comment hidden (obsolete)

Created attachment 349219 [details] Archive of layout-test-results from ews106 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 4 2018-09-07 17:24:45 PDT Comment hidden (obsolete)

Comment on attachment 349214 [details] Patch Attachment 349214 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/9134779 New failing tests: media/mediacapabilities/mediacapabilities-types.html

EWS Watchlist

Comment 5 2018-09-07 17:55:01 PDT Comment hidden (obsolete)

Comment on attachment 349214 [details] Patch Attachment 349214 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/9134807 New failing tests: media/mediacapabilities/mediacapabilities-types.html

EWS Watchlist

Comment 6 2018-09-07 17:55:03 PDT Comment hidden (obsolete)

Created attachment 349220 [details] Archive of layout-test-results from ews112 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 7 2018-09-07 18:16:40 PDT Comment hidden (obsolete)

Comment on attachment 349214 [details] Patch Attachment 349214 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/9134844 New failing tests: media/mediacapabilities/mediacapabilities-types.html

EWS Watchlist

Comment 8 2018-09-07 18:16:42 PDT Comment hidden (obsolete)

Created attachment 349225 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4

EWS Watchlist

Comment 9 2018-09-07 19:15:45 PDT Comment hidden (obsolete)

Comment on attachment 349214 [details] Patch Attachment 349214 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/9135813 New failing tests: media/mediacapabilities/mediacapabilities-types.html

EWS Watchlist

Comment 10 2018-09-07 19:15:47 PDT Comment hidden (obsolete)

Created attachment 349230 [details] Archive of layout-test-results from ews103 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 11 2018-09-07 20:17:09 PDT Comment hidden (obsolete)

Comment on attachment 349214 [details] Patch Attachment 349214 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/9136019 New failing tests: media/mediacapabilities/mediacapabilities-types.html

EWS Watchlist

Comment 12 2018-09-07 20:17:11 PDT Comment hidden (obsolete)

Created attachment 349235 [details] Archive of layout-test-results from ews124 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4

Jer Noble

Comment 13 2018-09-10 09:57:36 PDT

Created attachment 349315 [details] Patch

Jer Noble

Comment 14 2018-09-10 10:07:17 PDT

Created attachment 349317 [details] Patch

Eric Carlson

Comment 15 2018-09-11 15:37:28 PDT

Comment on attachment 349317 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=349317&action=review > Source/WebCore/platform/mediastream/mac/DisplayCaptureSourceCocoa.h:39 > +typedef struct __CVBuffer *CVPixelBufferRef; > +typedef struct __IOSurface *IOSurfaceRef; > + Is this supposed to be part of this patch?

Jer Noble

Comment 16 2018-09-11 15:47:39 PDT

(In reply to Eric Carlson from comment #15) > Comment on attachment 349317 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=349317&action=review > > > Source/WebCore/platform/mediastream/mac/DisplayCaptureSourceCocoa.h:39 > > +typedef struct __CVBuffer *CVPixelBufferRef; > > +typedef struct __IOSurface *IOSurfaceRef; > > + > > Is this supposed to be part of this patch? Yes. Changing the order of files in SourcesCocoa.txt exposed a pre-existing issue where those types were not directly defined in DisplayCaptureSourceCocoa.h.

WebKit Commit Bot

Comment 17 2018-09-11 16:18:26 PDT

Comment on attachment 349317 [details] Patch Clearing flags on attachment: 349317 Committed r235919: <https://trac.webkit.org/changeset/235919>

WebKit Commit Bot

Comment 18 2018-09-11 16:18:27 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 19 2018-09-11 16:19:29 PDT

<rdar://problem/44361779>

Note You need to log in before you can comment on or make changes to this bug.