Bug 189433

Summary:

Touch Bar displays an active PIP button for audio elements (and it doesn't do anything)

Product:

WebKit

Reporter:

Matt Rajca <mrajca>

Component:

Media

Assignee:

Matt Rajca <mrajca>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

eric.carlson

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	eric.carlson: review+

Matt Rajca

Reported 2018-09-07 14:41:17 PDT

When playing an audio element, the media Touch Bar displays an active PIP button even though only videos are PIP-able. Pressing it does not do anything. It seems like canTogglePictureInPicture is set to YES unconditionally on the WebPlaybackControlsManager. It should be set based on the media type.

Attachments
Patch (32.46 KB, patch) 2018-09-07 14:59 PDT, Matt Rajca	no flags	Details Formatted Diff Diff
Patch (32.43 KB, patch) 2018-09-07 15:25 PDT, Matt Rajca	no flags	Details Formatted Diff Diff
Patch (33.61 KB, patch) 2018-09-07 15:40 PDT, Matt Rajca	no flags	Details Formatted Diff Diff
Patch (33.69 KB, patch) 2018-09-07 16:40 PDT, Matt Rajca	eric.carlson: review+	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.